From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 2/2] rdma/cm: allow user to specify IP to DGID mapping Date: Tue, 20 Oct 2009 13:18:21 -0600 Message-ID: <20091020191821.GI14520@obsidianresearch.com> References: <15ddcffd0910071523w4f229b14j905ad170ceb8c21f@mail.gmail.com> <9F4DE6A2B4F644698E94F00C4FEEF30A@amr.corp.intel.com> <0A383504E0E54C949DEF84405E3AE92F@amr.corp.intel.com> <15ddcffd0910081633q20d98abfg41a9f4e781e486b1@mail.gmail.com> <859D79BFCA4741F393AABF76BBCA4F7B@amr.corp.intel.com> <4ADD8F5F.3010008@voltaire.com> <9F76F7CD7B9048E8821A1B05CC5FAFE8@amr.corp.intel.com> <20091020183132.GE14520@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sean Hefty Cc: 'Or Gerlitz' , 'Or Gerlitz' , linux-rdma , Roland Dreier List-Id: linux-rdma@vger.kernel.org On Tue, Oct 20, 2009 at 12:13:03PM -0700, Sean Hefty wrote: > >> rdma_bind_addr fills in the service id according RDMA IP CM service > >> annex. > > > >Hm? If the sockaddr_ib contains the service ID why override it in the > >kernel? > > > >The AF_IB/PS_IB flow in the kernel side must just use straight service > >IDs. > > I agree. But we can still support AF_IB/PS_TCP by simply assigning > the service ID correctly. rdma_bind_addr only needs to fill in a > service id if one is not given. This should enable 'one is not given' == 0 service ID? Is there any reason to ever use AF_IB/PS_TCP on the listening side? What functional difference are you imagining compared to listening on AF_INET/PS_TCP? > interoperability. I realize that IB doesn't have the concept of a > service ID for the active side of a connection, but the RDMA IP CM > Service header carries the source port. And rdma_bind_addr is > called by rdma_resolve_addr, so it needs to be updated. Hmm, yes, messy.. > Even once PS_IB is added, we need to make sure that it doesn't collide with > PS_TCP at the IB service ID level, or IB will be in the same situation that > iWarp is in with space collisions. I thought there was already a single service ID registration list that was shared between RDMA CM and IB CM? Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html