Re: [PATCH] opensm/osm_vendor_ibumad.c: Add environment variable to change max retries

[Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>]

On 14:33 Mon 19 Oct     , Hal Rosenstock wrote:
> 

Why do you need this?

And why did you choose to use environment variable and not command
line/config option? I think that it is less obvious.

Sasha

> Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> diff --git a/opensm/libvendor/osm_vendor_ibumad.c b/opensm/libvendor/osm_vendor_ibumad.c
> index 8d3c680..01250fb 100644
> --- a/opensm/libvendor/osm_vendor_ibumad.c
> +++ b/opensm/libvendor/osm_vendor_ibumad.c
> @@ -446,6 +446,17 @@ osm_vendor_init(IN osm_vendor_t * const p_vend,
>  	p_vend->p_log = p_log;
>  	p_vend->timeout = timeout;
>  	p_vend->max_retries = OSM_DEFAULT_RETRY_COUNT;
> +
> +	if ((max = getenv("OSM_UMAD_MAX_RETRIES")) != NULL) {
> +		int tmp = strtol(max, NULL, 0);
> +		if (tmp > 0)
> +			p_vend->max_retries = tmp;
> +		else
> +			OSM_LOG(p_vend->p_log, OSM_LOG_ERROR, "Error:"
> +				"OSM_UMAD_MAX_RETRIES=%d is invalid\n",
> +				tmp);
> +        }
> +
>  	pthread_mutex_init(&p_vend->cb_mutex, NULL);
>  	pthread_mutex_init(&p_vend->match_tbl_mutex, NULL);
>  	p_vend->umad_port_id = -1;
> @@ -476,12 +487,13 @@ osm_vendor_init(IN osm_vendor_t * const p_vend,
>  			p_vend->mtbl.max = tmp;
>  		else
>  			OSM_LOG(p_vend->p_log, OSM_LOG_ERROR, "Error:"
> -				"OSM_UMAD_MAX_PENDING=%d is invalid",
> +				"OSM_UMAD_MAX_PENDING=%d is invalid\n",
>  				tmp);
>  	}
>  
> -	OSM_LOG(p_vend->p_log, OSM_LOG_INFO, "%d pending umads specified\n",
> -		p_vend->mtbl.max);
> +	OSM_LOG(p_vend->p_log, OSM_LOG_INFO,
> +		"%d max retries %d max pending umads specified\n",
> +		p_vend->max_retries, p_vend->mtbl.max);
>  
>  	p_vend->mtbl.tbl = calloc(p_vend->mtbl.max, sizeof(*(p_vend->mtbl.tbl)));
>  	if (!p_vend->mtbl.tbl) {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html