From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Khapyorsky Subject: Re: [PATCH] opensm/osm_vendor_ibumad.c: Add environment variable to change max retries Date: Thu, 22 Oct 2009 15:50:04 +0200 Message-ID: <20091022135004.GK20210@me> References: <20091019183342.GA28926@comcast.net> <20091022122443.GF20210@me> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hal Rosenstock Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 08:56 Thu 22 Oct , Hal Rosenstock wrote: > > > > Why do you need this? > > It is useful in some clusters where the default behavior is > insufficient I would suppose that by itself this may indicate some external issues like bad connectivity (cabling) or similar and some investigation would be helpful there (regardless to number of retries). > and control over the number of retries helps and there is > no vendor API support for this. > > > And why did you choose to use environment variable and not command > > line/config option? I think that it is less obvious. > > It was modeled after OSM_UMAD_MAX_PENDING. It was internal libvendor hack (which is also not 100% clean :)) controlling ibumad implementation specific parameter. Unlike this a number of MAD retries (similar to MAD response timeout value) has more generic meaning. > It could be made a command > line/options file item. Is that your preference ? I think command line/config option is a way to do it. Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html