From: Hal Rosenstock <hnrose-Wuw85uim5zDR7s880joybQ@public.gmane.org>
To: sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] opensm/osm_sa_mcmember_record.c: Validate P_Key on IPoIB signed MGIDs
Date: Thu, 22 Oct 2009 10:59:46 -0400 [thread overview]
Message-ID: <20091022145946.GA7932@comcast.net> (raw)
Per RFC 4391 rules for P_Key portion of MGIDs needing to be
full member and valid P_Key
Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
diff --git a/opensm/opensm/osm_sa_mcmember_record.c b/opensm/opensm/osm_sa_mcmember_record.c
index dd01eed..a185238 100644
--- a/opensm/opensm/osm_sa_mcmember_record.c
+++ b/opensm/opensm/osm_sa_mcmember_record.c
@@ -3,6 +3,7 @@
* Copyright (c) 2002-2005 Mellanox Technologies LTD. All rights reserved.
* Copyright (c) 1996-2003 Intel Corporation. All rights reserved.
* Copyright (c) 2008 Xsigo Systems Inc. All rights reserved.
+ * Copyright (c) 2009 HNR Consulting. All rights reserved.
*
* This software is available to you under a choice of one of two
* licenses. You may choose to be licensed under the terms of the GNU
@@ -516,6 +517,7 @@ static ib_api_status_t validate_requested_mgid(IN osm_sa_t * sa,
p_mcm_rec)
{
uint16_t signature;
+ ib_net16_t pkey;
boolean_t valid = TRUE;
OSM_LOG_ENTER(sa->p_log);
@@ -555,6 +557,16 @@ static ib_api_status_t validate_requested_mgid(IN osm_sa_t * sa,
*
*/
if (signature == 0x401B || signature == 0x601B) {
+ /* Validate P_Key portion of MGID per RFC 4391 */
+ memcpy(&pkey, &(p_mcm_rec->mgid.raw[4]), sizeof(pkey));
+ if (!ib_pkey_is_full_member(pkey) || ib_pkey_is_invalid(pkey)) {
+ OSM_LOG(sa->p_log, OSM_LOG_ERROR, "ERR 1B27: "
+ "MGID uses limited or invalid P_Key 0x%x\n",
+ cl_ntoh16(pkey));
+ valid = FALSE;
+ goto Exit;
+ }
+
OSM_LOG(sa->p_log, OSM_LOG_DEBUG,
"Skipping MGID Validation for IPoIB Signed (0x%04X) MGIDs\n",
signature);
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
reply other threads:[~2009-10-22 14:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091022145946.GA7932@comcast.net \
--to=hnrose-wuw85uim5zdr7s880joybq@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox