[PATCH] opensm/osm_ucast_cache.c: Eliminate unneeded define

[PATCH] opensm/osm_ucast_cache.c: Eliminate unneeded define

[Hal Rosenstock]

Also, cosmetic change to OSM_LOG message

Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
diff --git a/opensm/opensm/osm_ucast_cache.c b/opensm/opensm/osm_ucast_cache.c
index 4700c5f..09bbf33 100644
--- a/opensm/opensm/osm_ucast_cache.c
+++ b/opensm/opensm/osm_ucast_cache.c
@@ -59,8 +59,6 @@
 #include <opensm/osm_node.h>
 #include <opensm/osm_port.h>
 
-#define CACHE_SW_PORTS 36
-
 typedef struct cache_port {
 	boolean_t is_leaf;
 	uint16_t remote_lid_ho;
@@ -420,7 +418,7 @@ void osm_ucast_cache_invalidate(osm_ucast_mgr_t * p_mgr)
 	}
 	cl_qmap_remove_all(&p_mgr->cache_sw_tbl);
 
-	OSM_LOG(p_mgr->p_log, OSM_LOG_VERBOSE, "Unicast Cache Invalidated.\n");
+	OSM_LOG(p_mgr->p_log, OSM_LOG_VERBOSE, "Unicast cache invalidated\n");
 Exit:
 	OSM_LOG_EXIT(p_mgr->p_log);
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] opensm/osm_ucast_cache.c: Eliminate unneeded define

[Sasha Khapyorsky]

On 08:50 Wed 21 Oct     , Hal Rosenstock wrote:
> 
> Also, cosmetic change to OSM_LOG message

Please don't mix.

I used "Unicast Cache" (with upper case starting letters) as for a name.

> 
> Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Applied with changes. Thanks.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] opensm/osm_ucast_cache.c: Eliminate unneeded define

[Hal Rosenstock]

On Thu, Oct 22, 2009 at 11:01 AM, Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org> wrote:
> On 08:50 Wed 21 Oct     , Hal Rosenstock wrote:
>>
>> Also, cosmetic change to OSM_LOG message
>
> Please don't mix.
>
> I used "Unicast Cache" (with upper case starting letters) as for a name.

A nit but any reason for that one message being inconsistent (in terms
of case) with the other log messages there ?

-- Hal

>
>>
>> Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Applied with changes. Thanks.
>
> Sasha
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] opensm/osm_ucast_cache.c: Eliminate unneeded define

[Sasha Khapyorsky]

On 11:31 Mon 02 Nov     , Hal Rosenstock wrote:
> 
> A nit but any reason for that one message being inconsistent (in terms
> of case) with the other log messages there ?

Other messages are debug printouts and cannot be compared.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] opensm/osm_ucast_cache.c: Eliminate unneeded define

[Hal Rosenstock]

On Mon, Nov 2, 2009 at 12:01 PM, Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org> wrote:
> On 11:31 Mon 02 Nov     , Hal Rosenstock wrote:
>>
>> A nit but any reason for that one message being inconsistent (in terms
>> of case) with the other log messages there ?
>
> Other messages are debug printouts and cannot be compared.

That seems pretty arbitrary to me. I don't think that's the case with
different levels of printing elsewhere.

-- Hal

>
> Sasha
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html