public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
Cc: "Eli Dorfman (Voltaire)"
	<dorfman.eli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Julia Volynsky <juliav-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Subject: Re: [ofa-general] [PATCH -- repost] infiniband-diags: Fix IB network discovery from switch node.
Date: Fri, 23 Oct 2009 05:14:25 +0200	[thread overview]
Message-ID: <20091023031425.GM20210@me> (raw)
In-Reply-To: <20091007103525.8982fc2f.weiny2-i2BcT+NCU+M@public.gmane.org>

Hi Ira,

On 10:35 Wed 07 Oct     , Ira Weiny wrote:
> 
> Perhaps you missed this patch the first time around.

Right, I missed this masked inside this email message.

And yes, it would be better to send a patches as separate emails. And of
course you can still use In-Replay-To: email header line to keep a
discussion thread.

> Eli, verified that it worked for him on the switch as well as works for me.  This applies to current master as is.
> 
> Eli, I added you as signing off on this.
> 
> Thanks guys,
> Ira
> 
> From: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
> Date: Tue, 22 Sep 2009 11:08:28 -0700
> Subject: [PATCH] infiniband-diags/libibnetdisc/src/ibnetdisc.c: fix bug in single node processing.
> 
> 	Eli fixed an issue with running ibnetdiscover from a switch but it
> 	introduced a bug in processing a single switch:
> 
> 17:19:42 > ./iblinkinfo -S 0x000b8cffff00490c
> Switch 0x000b8cffff00490c MT47396 Infiniscale-III Mellanox Technologies:
> ...
>            8   11[  ] ==( 4X 2.5 Gbps   Down/ Polling)==>             [  ] "" ( )
>            8   12[  ] ==( 4X 5.0 Gbps Active/  LinkUp)==>             [  ] "" ( )
>            8   13[  ] ==( 4X 2.5 Gbps   Down/ Polling)==>             [  ] "" ( )
> ...
> 
> 	The port we "come in on" when discovering the switch is not reported properly.
> 
> 	This patch reverses Eli's patch and fixes his original bug in a way
> 	which does not introduce the above issue.
> 
> Signed-off-by: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
> Signed-off-by: "Eli Dorfman (Voltaire)" <dorfman.eli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Applied. Thanks.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2009-10-23  3:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4A9548AA.4020900@gmail.com>
2009-09-24  0:24 ` [ofa-general] [PATCH] infiniband-diags: Fix IB network discovery from switch node Ira Weiny
2009-09-29 16:16   ` Eli Dorfman (Voltaire)
     [not found]     ` <4AC232D5.2060806-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-09-29 23:48       ` Ira Weiny
     [not found]         ` <20090929164842.c1ab7d06.weiny2-i2BcT+NCU+M@public.gmane.org>
2009-09-30  8:33           ` Eli Dorfman (Voltaire)
2009-10-07 17:35           ` [ofa-general] [PATCH -- repost] " Ira Weiny
     [not found]             ` <20091007103525.8982fc2f.weiny2-i2BcT+NCU+M@public.gmane.org>
2009-10-23  3:14               ` Sasha Khapyorsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091023031425.GM20210@me \
    --to=sashak-smomgflxvozwk0htik3j/w@public.gmane.org \
    --cc=dorfman.eli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=juliav-smomgflXvOZWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=weiny2-i2BcT+NCU+M@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox