From: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
Cc: Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] opensm/mcast_tbl: set max_mlid_ho as actually configured mlid
Date: Fri, 30 Oct 2009 01:02:46 +0200 [thread overview]
Message-ID: <20091029230246.GN20136@me> (raw)
In-Reply-To: <20091029154431.72fc32bd.weiny2-i2BcT+NCU+M@public.gmane.org>
Hi Ira,
Thanks for reporting.
On 15:44 Thu 29 Oct , Ira Weiny wrote:
>
> OpenSM $ mlid_ho 49152; p_tbl->max_mlid_ho 49152
> mlid_ho 49154; p_tbl->max_mlid_ho 49153
> opensm: osm_mcast_tbl.c:107: osm_mcast_tbl_set: Assertion `mlid_ho <= p_tbl->max_mlid_ho' failed.
> Aborted (core dumped)
Small fix:
diff --git a/opensm/opensm/osm_mcast_tbl.c b/opensm/opensm/osm_mcast_tbl.c
index eee9290..0a45904 100644
--- a/opensm/opensm/osm_mcast_tbl.c
+++ b/opensm/opensm/osm_mcast_tbl.c
@@ -145,7 +145,7 @@ int osm_mcast_tbl_realloc(IN osm_mcast_tbl_t * p_tbl, IN uintn_t mlid_offset)
p_tbl->p_mask_tbl = p_mask_tbl;
p_tbl->mft_depth = mft_depth;
done:
- p_tbl->max_mlid_ho = mlid_offset + IB_LID_MCAST_START_HO - 1;
+ p_tbl->max_mlid_ho = mlid_offset + IB_LID_MCAST_START_HO;
return 0;
}
Does it work for you?
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-10-29 23:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 23:48 [PATCHv5] opensm: Reduce heap consumption by multicast routing tables (MFTs) Hal Rosenstock
[not found] ` <20091023234856.GA1482-Wuw85uim5zDR7s880joybQ@public.gmane.org>
2009-10-29 19:17 ` Sasha Khapyorsky
2009-10-29 19:18 ` [PATCH] opensm/osm_mcast_mgr: simplify alloc_mfts() Sasha Khapyorsky
2009-10-29 19:19 ` [PATCH] opensm/osm_mcast_tbl: remove redundant checks Sasha Khapyorsky
2009-10-30 13:47 ` Hal Rosenstock
2009-10-29 19:19 ` [PATCH] opensm/mcast_tbl: set max_mlid_ho as actually configured mlid Sasha Khapyorsky
2009-10-29 22:44 ` Ira Weiny
[not found] ` <20091029154431.72fc32bd.weiny2-i2BcT+NCU+M@public.gmane.org>
2009-10-29 23:02 ` Sasha Khapyorsky [this message]
2009-10-29 23:09 ` Ira Weiny
[not found] ` <20091029160958.d13ed53e.weiny2-i2BcT+NCU+M@public.gmane.org>
2009-10-30 0:32 ` Sasha Khapyorsky
2009-10-30 13:47 ` [PATCHv5] opensm: Reduce heap consumption by multicast routing tables (MFTs) Hal Rosenstock
[not found] ` <f0e08f230910300647q274e4e76v70c60a978f84309c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-30 19:55 ` Sasha Khapyorsky
[not found] <4AEAEA86.8080309@systemfabricworks.com>
[not found] ` <4AEAEA86.8080309-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2009-10-30 13:48 ` [PATCH] opensm/mcast_tbl: set max_mlid_ho as actually configured mlid Hal Rosenstock
[not found] ` <f0e08f230910300648m4d802f57w2910cea678a3cd1f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-30 20:06 ` Sasha Khapyorsky
2009-10-30 20:44 ` Hal Rosenstock
[not found] ` <f0e08f230910301344j5b9564a5k9b77fd4e43e48376-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-30 21:31 ` Sasha Khapyorsky
2009-11-02 16:18 ` Hal Rosenstock
[not found] ` <f0e08f230911020818n2f2f4dcai5c920dbfa98551de-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-11-02 16:43 ` Sasha Khapyorsky
2009-11-02 16:44 ` Hal Rosenstock
[not found] ` <f0e08f230911020844i7f52b492ifdcbadc2babbf4ae-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-11-02 16:50 ` Sasha Khapyorsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091029230246.GN20136@me \
--to=sashak-smomgflxvozwk0htik3j/w@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=weiny2-i2BcT+NCU+M@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox