From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Khapyorsky Subject: Re: [PATCH] opensm/mcast_tbl: set max_mlid_ho as actually configured mlid Date: Fri, 30 Oct 2009 22:06:20 +0200 Message-ID: <20091030200620.GB5829@me> References: <4AEAEA86.8080309@systemfabricworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hal Rosenstock Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 09:48 Fri 30 Oct , Hal Rosenstock wrote: > > > > diff --git a/opensm/opensm/osm_mcast_tbl.c b/opensm/opensm/osm_mcas= t_tbl.c > > index b5ae6f2..eee9290 100644 > > --- a/opensm/opensm/osm_mcast_tbl.c > > +++ b/opensm/opensm/osm_mcast_tbl.c > > @@ -122,7 +122,7 @@ int osm_mcast_tbl_realloc(IN osm_mcast_tbl_t * = p_tbl, IN > > uintn_t mlid_offset) > > =A0 =A0 =A0 =A0uint16_t (*p_mask_tbl)[][IB_MCAST_POSITION_MAX]; > > > > =A0 =A0 =A0 =A0if (mlid_offset < p_tbl->mft_depth) > > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 return 0; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 goto done; >=20 > Why should max_mlid_ho be changed when < mft_depth ? To be equal to an actually configured max mlid value (not a size of mcast table allocation). > Doing so makes group removal not work properly. This may have this issue, but not due to fact of max_mlid_ho change, bu= t due to invalid check in osm_mcast_tbl_clear_mlid(). I think there it should be something like: diff --git a/opensm/opensm/osm_mcast_tbl.c b/opensm/opensm/osm_mcast_tb= l.c index 0a45904..a599e56 100644 --- a/opensm/opensm/osm_mcast_tbl.c +++ b/opensm/opensm/osm_mcast_tbl.c @@ -245,8 +245,8 @@ void osm_mcast_tbl_clear_mlid(IN osm_mcast_tbl_t * = p_tbl, IN uint16_t mlid_ho) CL_ASSERT(p_tbl); CL_ASSERT(mlid_ho >=3D IB_LID_MCAST_START_HO); =20 - if (p_tbl->p_mask_tbl && mlid_ho <=3D p_tbl->max_mlid_ho) { - mlid_offset =3D mlid_ho - IB_LID_MCAST_START_HO; + mlid_offset =3D mlid_ho - IB_LID_MCAST_START_HO; + if (p_tbl->p_mask_tbl && mlid_offset < p_tbl->mft_depth) { for (i =3D 0; i <=3D p_tbl->max_position; i++) (*p_tbl->p_mask_tbl)[mlid_offset][i] =3D 0; } Does it make sense? Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html