Re: [PATCH] opensm/osm_link_mgr.c: In link_mgr_set_physp_pi, only call link_mgr_get_smsl when LID valid

[Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>]

On 19:31 Fri 30 Oct     , Hal Rosenstock wrote:
> Hi Sasha,
> 
> On Fri, Oct 30, 2009 at 5:17 PM, Sasha Khapyorsky <sashak-smomgflXvObQFizaE/u3fw@public.gmane.orgm> wrote:
> >
> > Hi Hal,
> >
> > On 09:27 Wed 23 Sep     , Hal Rosenstock wrote:
> >>
> >> Fix seg fault which occurs when get_osm_switch_from_port is
> >> called with NULL port (which in this case was caused by calling
> >> cl_ptr_vector_get on port LID table with LID 0)
> >
> > Would be really useful to describe when and why this (LID = 0) can
> > happen.
> 
> Thought we resolved this in "osm_link_mgr.c:link_mgr_get_smsl question" thread.

It is not for me. It is a change log and people which can read this
over years may not follow any mailing thread on the list.

> > diff --git a/opensm/opensm/osm_link_mgr.c b/opensm/opensm/osm_link_mgr.c
> > index 4d4be56..217f51e 100644
> > --- a/opensm/opensm/osm_link_mgr.c
> > +++ b/opensm/opensm/osm_link_mgr.c
> > @@ -68,7 +68,8 @@ static uint8_t link_mgr_get_smsl(IN osm_sm_t * sm, IN
> > osm_physp_t * p_physp)
> >
> >          OSM_LOG_ENTER(sm->p_log);
> >
> > -        if (p_osm->routing_engine_used != OSM_ROUTING_ENGINE_TYPE_LASH) {
> > +        if (p_osm->routing_engine_used != OSM_ROUTING_ENGINE_TYPE_LASH
> > +            || !(slid = osm_physp_get_base_lid(p_physp))) {
> >                  /* Use default SL if lash routing is not used */
> >                  OSM_LOG_EXIT(sm->p_log);
> >                  return (sm->p_subn->opt.sm_sl);
> > @@ -80,7 +81,6 @@ static uint8_t link_mgr_get_smsl(IN osm_sm_t * sm, IN
> > osm_physp_t * p_physp)
> >              cl_ptr_vector_get(&sm->p_subn->port_lid_tbl, cl_ntoh16(smlid));
> >
> >          /* Find osm_port of the source = p_physp */
> > -        slid = osm_physp_get_base_lid(p_physp);
> >          p_src_port =
> >              cl_ptr_vector_get(&sm->p_subn->port_lid_tbl, cl_ntoh16(slid));
> >
> >
> > Wouldn't it be the same functionally?
> 
> Yes,
> 
> Do you want an updated patch ?

No need, I have it already.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html