Re: [PATCH] opensm/osm_sm_mad_ctrl.c: In sm_mad_ctrl_send_err_cb, set init failure on PKeyTable and QoS initialization failure

Re: [PATCH] opensm/osm_sm_mad_ctrl.c: In sm_mad_ctrl_send_err_cb, set init failure on PKeyTable and QoS initialization failure

[Hal Rosenstock]

On Thu, Oct 29, 2009 at 9:22 PM,  Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org> wrote:
>
>
> On 09:13 Mon 10 Aug     , Hal Rosenstock wrote:
>>
>> Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>> diff --git a/opensm/opensm/osm_sm_mad_ctrl.c
>> b/opensm/opensm/osm_sm_mad_ctrl.c
>> index 791c848..f0bc407 100644
>> --- a/opensm/opensm/osm_sm_mad_ctrl.c
>> +++ b/opensm/opensm/osm_sm_mad_ctrl.c
>> @@ -723,7 +723,10 @@ static void sm_mad_ctrl_send_err_cb(IN void *context,
>> IN osm_madw_t * p_madw)
>>              (p_smp->attr_id == IB_MAD_ATTR_PORT_INFO ||
>>               p_smp->attr_id == IB_MAD_ATTR_MCAST_FWD_TBL ||
>>               p_smp->attr_id == IB_MAD_ATTR_SWITCH_INFO ||
>> -             p_smp->attr_id == IB_MAD_ATTR_LIN_FWD_TBL)) {
>> +             p_smp->attr_id == IB_MAD_ATTR_LIN_FWD_TBL ||
>> +             p_smp->attr_id == IB_MAD_ATTR_P_KEY_TABLE ||
>> +             p_smp->attr_id == IB_MAD_ATTR_SLVL_TABLE ||
>> +             p_smp->attr_id == IB_MAD_ATTR_VL_ARBITRATION)) {
>
> Why this change?

Why not ? Aren't these initialization failures ? Why should they be
excluded ? If I recall correctly, they were originally excluded due to
"newness" but that was years ago.

> Any real issue with current behavior (reporting errors and continue)?

In subnets using SL based routing seems that SLVL is critical. One
might want PKey table failures to be treated similarly when partitions
are configured. It's less compelling for VL arbitration.

-- Hal

>
> Sasha
>
>>                  OSM_LOG(p_ctrl->p_log, OSM_LOG_ERROR, "ERR 3119: "
>>                          "Set method failed for attribute 0x%X (%s)\n",
>>                          cl_ntoh16(p_smp->attr_id),
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] opensm/osm_sm_mad_ctrl.c: In sm_mad_ctrl_send_err_cb, set init failure on PKeyTable and QoS initialization failure

[Sasha Khapyorsky]

On 17:45 Fri 30 Oct     , Hal Rosenstock wrote:
> On Thu, Oct 29, 2009 at 9:22 PM,  Sasha Khapyorsky <sashak@voltaire.com> wrote:
> >
> >
> > On 09:13 Mon 10 Aug     , Hal Rosenstock wrote:
> >>
> >> Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> ---
> >> diff --git a/opensm/opensm/osm_sm_mad_ctrl.c
> >> b/opensm/opensm/osm_sm_mad_ctrl.c
> >> index 791c848..f0bc407 100644
> >> --- a/opensm/opensm/osm_sm_mad_ctrl.c
> >> +++ b/opensm/opensm/osm_sm_mad_ctrl.c
> >> @@ -723,7 +723,10 @@ static void sm_mad_ctrl_send_err_cb(IN void *context,
> >> IN osm_madw_t * p_madw)
> >>              (p_smp->attr_id == IB_MAD_ATTR_PORT_INFO ||
> >>               p_smp->attr_id == IB_MAD_ATTR_MCAST_FWD_TBL ||
> >>               p_smp->attr_id == IB_MAD_ATTR_SWITCH_INFO ||
> >> -             p_smp->attr_id == IB_MAD_ATTR_LIN_FWD_TBL)) {
> >> +             p_smp->attr_id == IB_MAD_ATTR_LIN_FWD_TBL ||
> >> +             p_smp->attr_id == IB_MAD_ATTR_P_KEY_TABLE ||
> >> +             p_smp->attr_id == IB_MAD_ATTR_SLVL_TABLE ||
> >> +             p_smp->attr_id == IB_MAD_ATTR_VL_ARBITRATION)) {
> >
> > Why this change?
> 
> Why not ? Aren't these initialization failures ? Why should they be
> excluded ? If I recall correctly, they were originally excluded due to
> "newness" but that was years ago.

Ok, let's try this.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html