[PATCH] opensm/osm_mcast_mgr.c: fix return value on alloc_mfts() failures

[PATCH] opensm/osm_mcast_mgr.c: fix return value on alloc_mfts() failures

[Sasha Khapyorsky]

When alloc_mfts() fails and multicast routing calculation interrupted
return -1 value to a caller.

Signed-off-by: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
---
 opensm/opensm/osm_mcast_mgr.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/opensm/opensm/osm_mcast_mgr.c b/opensm/opensm/osm_mcast_mgr.c
index 105e905..7bd7add 100644
--- a/opensm/opensm/osm_mcast_mgr.c
+++ b/opensm/opensm/osm_mcast_mgr.c
@@ -1066,6 +1066,7 @@ int osm_mcast_mgr_process(osm_sm_t * sm)
 	if (alloc_mfts(sm)) {
 		OSM_LOG(sm->p_log, OSM_LOG_ERROR,
 			"ERR 0A07: alloc_mfts failed\n");
+		ret = -1;
 		goto exit;
 	}
 
@@ -1110,6 +1111,7 @@ int osm_mcast_mgr_process_mgroups(osm_sm_t * sm)
 	if (alloc_mfts(sm)) {
 		OSM_LOG(sm->p_log, OSM_LOG_ERROR,
 			"ERR 0A09: alloc_mfts failed\n");
+		ret = -1;
 		goto exit;
 	}
 
-- 
1.6.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] opensm/osm_mcast_mgr.c: fix return value on alloc_mfts() failures

[Hal Rosenstock]

On Wed, Nov 11, 2009 at 1:33 PM, Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org> wrote:
>
> When alloc_mfts() fails and multicast routing calculation interrupted
> return -1 value to a caller.

Yes, that fixes the return value but nothing (at least currently)
takes advantage of that. Is that the next step ?

-- Hal

>
> Signed-off-by: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
> ---
>  opensm/opensm/osm_mcast_mgr.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/opensm/opensm/osm_mcast_mgr.c b/opensm/opensm/osm_mcast_mgr.c
> index 105e905..7bd7add 100644
> --- a/opensm/opensm/osm_mcast_mgr.c
> +++ b/opensm/opensm/osm_mcast_mgr.c
> @@ -1066,6 +1066,7 @@ int osm_mcast_mgr_process(osm_sm_t * sm)
>        if (alloc_mfts(sm)) {
>                OSM_LOG(sm->p_log, OSM_LOG_ERROR,
>                        "ERR 0A07: alloc_mfts failed\n");
> +               ret = -1;
>                goto exit;
>        }
>
> @@ -1110,6 +1111,7 @@ int osm_mcast_mgr_process_mgroups(osm_sm_t * sm)
>        if (alloc_mfts(sm)) {
>                OSM_LOG(sm->p_log, OSM_LOG_ERROR,
>                        "ERR 0A09: alloc_mfts failed\n");
> +               ret = -1;
>                goto exit;
>        }
>
> --
> 1.6.5.2
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] opensm/osm_mcast_mgr.c: fix return value on alloc_mfts() failures

[Sasha Khapyorsky]

On 15:25 Wed 11 Nov     , Hal Rosenstock wrote:
> 
> Yes, that fixes the return value but nothing (at least currently)
> takes advantage of that. Is that the next step ?

Yes, it should be done this way.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html