Re: [infiniband-diags] [PATCH] [2/2] split out scan specific data from ibnd_node_t

Al Chu
2009-11-12T17:51:08Z

Hey Sasha,

> Really? I thought that it could be a useful data for "advanced" uses.

It was removed in commit 094f922a34d6378d6a3bd1d137f90d6530685f94. It
was a simpler version of a patch that Ira had proposed on the mailing
list.

> I cannot understand why are you trying to make things there as
> "private" as technically possible (even on price of extra code size
> and complexity). Finally it is an open source stuff, so let to users
> to use it how they want and for their own responsibility. :)

At the core of this patch (as well as some other patches I've submitted
on libibnetdiscover before), is cleaning up the interface of
libibnetdisc to be just the "core" of libibnetdisc. We could stick
anything into the public structs that could have potential usefulness,
but at some point I think we need to limit ourselves to only the core
stuff. Why not add the ibmad_port to the structs? Or instead of
putting just the guids or lids in the structs, why not also the pkeys,
capability masks, or VL tables?

Al

On Thu, 2009-11-12 at 18:31 +0200, Sasha Khapyorsky wrote:
> On 10:34 Fri 06 Nov , Al Chu wrote:
> > >
> > > Why do you want to remove this? port->path_portid can be useful for
> > > logging, specific querying, etc.. Even node->dnext can be helpful for
> > > some "advanced" use too.
> >
> > The 'nodesdist' array (which is what the 'dnext' pointer is used for) is
> > only used during the scan and is no longer available publicly.
>
> Really? I thought that it could be a useful data for "advanced" uses.
>
> > So the
> > 'dnext' pointer doesn't serve a purpose being in the public ibnd_node_t
> > struct.
> >
> > Post scan, the 'path_portid' was ony used in ibnd_update_node(), which
> > is now removed.
>
> You are saying about libibnetdisc itself. My example was about an
> application which uses this. For instance after discovery application
> may want to query some ports for its own purpose. What is wrong with
> that?
>
> > In addition, Ira and I felt it is one of the fields
> > that shouldn't have been exported out of libibnetdisc, it is far too
> > "scan specific" and shouldn't be public.
>
> I cannot understand why are you trying to make things there as "private"
> as technically possible (even on price of extra code size and
> complexity). Finally it is an open source stuff, so let to users to use
> it how they want and for their own responsibility. :)
>
> Sasha
--
Albert Chu
chu11-i2BcT+NCU+M@public.gmane.org
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory