[PATCH] libibmad: Add support for PortInfo:McastPkeyTrapSuppressionEnabled

[PATCH] libibmad: Add support for PortInfo:McastPkeyTrapSuppressionEnabled

[Hal Rosenstock]

Per published MgtWG erratum RefID 4576

Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
diff --git a/libibmad/include/infiniband/mad.h b/libibmad/include/infiniband/mad.h
index b82b0d5..ed8fd71 100644
--- a/libibmad/include/infiniband/mad.h
+++ b/libibmad/include/infiniband/mad.h
@@ -357,6 +357,7 @@ enum MAD_FIELDS {
 	IB_PORT_QKEY_VIOL_F,
 	IB_PORT_GUID_CAP_F,
 	IB_PORT_CLIENT_REREG_F,
+	IB_PORT_MCAST_PKEY_SUPR_ENAB_F,
 	IB_PORT_SUBN_TIMEOUT_F,
 	IB_PORT_RESP_TIME_VAL_F,
 	IB_PORT_LOCAL_PHYS_ERR_F,
diff --git a/libibmad/src/fields.c b/libibmad/src/fields.c
index 98a0c60..c2f9585 100644
--- a/libibmad/src/fields.c
+++ b/libibmad/src/fields.c
@@ -162,6 +162,7 @@ static const ib_field_t ib_mad_f[] = {
 	{BITSOFFS(384, 16), "QkeyViolations", mad_dump_uint},
 	{BITSOFFS(400, 8), "GuidCap", mad_dump_uint},
 	{BITSOFFS(408, 1), "ClientReregister", mad_dump_uint},
+	{BITSOFFS(409, 1), "McastPkeyTrapSuppressionEnabled", mad_dump_uint},
 	{BITSOFFS(411, 5), "SubnetTimeout", mad_dump_uint},
 	{BITSOFFS(419, 5), "RespTimeVal", mad_dump_uint},
 	{BITSOFFS(424, 4), "LocalPhysErr", mad_dump_uint},
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libibmad: Add support for PortInfo:McastPkeyTrapSuppressionEnabled

[Sasha Khapyorsky]

On 09:10 Fri 06 Nov     , Hal Rosenstock wrote:
> 
> Per published MgtWG erratum RefID 4576

Please describe the change. Reference to private tracker's RefID number
is not enough.

Sasha

> 
> Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> diff --git a/libibmad/include/infiniband/mad.h b/libibmad/include/infiniband/mad.h
> index b82b0d5..ed8fd71 100644
> --- a/libibmad/include/infiniband/mad.h
> +++ b/libibmad/include/infiniband/mad.h
> @@ -357,6 +357,7 @@ enum MAD_FIELDS {
>  	IB_PORT_QKEY_VIOL_F,
>  	IB_PORT_GUID_CAP_F,
>  	IB_PORT_CLIENT_REREG_F,
> +	IB_PORT_MCAST_PKEY_SUPR_ENAB_F,
>  	IB_PORT_SUBN_TIMEOUT_F,
>  	IB_PORT_RESP_TIME_VAL_F,
>  	IB_PORT_LOCAL_PHYS_ERR_F,
> diff --git a/libibmad/src/fields.c b/libibmad/src/fields.c
> index 98a0c60..c2f9585 100644
> --- a/libibmad/src/fields.c
> +++ b/libibmad/src/fields.c
> @@ -162,6 +162,7 @@ static const ib_field_t ib_mad_f[] = {
>  	{BITSOFFS(384, 16), "QkeyViolations", mad_dump_uint},
>  	{BITSOFFS(400, 8), "GuidCap", mad_dump_uint},
>  	{BITSOFFS(408, 1), "ClientReregister", mad_dump_uint},
> +	{BITSOFFS(409, 1), "McastPkeyTrapSuppressionEnabled", mad_dump_uint},
>  	{BITSOFFS(411, 5), "SubnetTimeout", mad_dump_uint},
>  	{BITSOFFS(419, 5), "RespTimeVal", mad_dump_uint},
>  	{BITSOFFS(424, 4), "LocalPhysErr", mad_dump_uint},
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libibmad: Add support for PortInfo:McastPkeyTrapSuppressionEnabled

[Hal Rosenstock]

On Fri, Nov 6, 2009 at 1:02 PM, Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org> wrote:
> On 09:10 Fri 06 Nov     , Hal Rosenstock wrote:
>>
>> Per published MgtWG erratum RefID 4576
>
> Please describe the change.

Not sure what else you are looking for here. Is it a description of
the new field or a description of the patch which is trivial:
"Add support for new field to PortInfo"

> Reference to private tracker's RefID number
> is not enough.

It's not private as I've tried to explain before.

-- Hal

>
> Sasha
>
>>
>> Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>> diff --git a/libibmad/include/infiniband/mad.h b/libibmad/include/infiniband/mad.h
>> index b82b0d5..ed8fd71 100644
>> --- a/libibmad/include/infiniband/mad.h
>> +++ b/libibmad/include/infiniband/mad.h
>> @@ -357,6 +357,7 @@ enum MAD_FIELDS {
>>       IB_PORT_QKEY_VIOL_F,
>>       IB_PORT_GUID_CAP_F,
>>       IB_PORT_CLIENT_REREG_F,
>> +     IB_PORT_MCAST_PKEY_SUPR_ENAB_F,
>>       IB_PORT_SUBN_TIMEOUT_F,
>>       IB_PORT_RESP_TIME_VAL_F,
>>       IB_PORT_LOCAL_PHYS_ERR_F,
>> diff --git a/libibmad/src/fields.c b/libibmad/src/fields.c
>> index 98a0c60..c2f9585 100644
>> --- a/libibmad/src/fields.c
>> +++ b/libibmad/src/fields.c
>> @@ -162,6 +162,7 @@ static const ib_field_t ib_mad_f[] = {
>>       {BITSOFFS(384, 16), "QkeyViolations", mad_dump_uint},
>>       {BITSOFFS(400, 8), "GuidCap", mad_dump_uint},
>>       {BITSOFFS(408, 1), "ClientReregister", mad_dump_uint},
>> +     {BITSOFFS(409, 1), "McastPkeyTrapSuppressionEnabled", mad_dump_uint},
>>       {BITSOFFS(411, 5), "SubnetTimeout", mad_dump_uint},
>>       {BITSOFFS(419, 5), "RespTimeVal", mad_dump_uint},
>>       {BITSOFFS(424, 4), "LocalPhysErr", mad_dump_uint},
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libibmad: Add support for PortInfo:McastPkeyTrapSuppressionEnabled

[Sasha Khapyorsky]

On 14:35 Fri 06 Nov     , Hal Rosenstock wrote:
> On Fri, Nov 6, 2009 at 1:02 PM, Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org> wrote:
> > On 09:10 Fri 06 Nov     , Hal Rosenstock wrote:
> >>
> >> Per published MgtWG erratum RefID 4576
> >
> > Please describe the change.
> 
> Not sure what else you are looking for here.

Not just me. Many people may look over change log. And they are not
necessary must be a full time IBTA members (and/or even not full time
linux-rdma list observers). Likely that for non-IBTA members words
"MgtWG" and "RefID 4576" will not say a lot about the change.

And for me it will be required to log into members area of IBTA web site
(which is slow) and to search in the tracker for RefID 4576. It is just
in order to review a two lines patch.

> Is it a description of
> the new field or a description of the patch which is trivial:
> "Add support for new field to PortInfo"

What is this field, what should it indicate, what is
McastPkeyTrap, what is an issue with it, etc.. Nothing of this is
covered.

> > Reference to private tracker's RefID number
> > is not enough.
> 
> It's not private as I've tried to explain before.

You said this, but you never provided any link to where it is published.
Could you?

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libibmad: Add support for PortInfo:McastPkeyTrapSuppressionEnabled

[Hal Rosenstock]

On Thu, Nov 12, 2009 at 11:50 AM, Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org> wrote:
> On 14:35 Fri 06 Nov     , Hal Rosenstock wrote:
>> On Fri, Nov 6, 2009 at 1:02 PM, Sasha Khapyorsky <sashak-smomgflXvObQFizaE/u3fw@public.gmane.orgm> wrote:
>> > On 09:10 Fri 06 Nov     , Hal Rosenstock wrote:
>> >>
>> >> Per published MgtWG erratum RefID 4576
>> >
>> > Please describe the change.
>>
>> Not sure what else you are looking for here.
>
> Not just me. Many people may look over change log. And they are not
> necessary must be a full time IBTA members (and/or even not full time
> linux-rdma list observers). Likely that for non-IBTA members words
> "MgtWG" and "RefID 4576" will not say a lot about the change.
>
> And for me it will be required to log into members area of IBTA web site
> (which is slow) and to search in the tracker for RefID 4576. It is just
> in order to review a two lines patch.
>
>> Is it a description of
>> the new field or a description of the patch which is trivial:
>> "Add support for new field to PortInfo"
>
> What is this field, what should it indicate, what is
> McastPkeyTrap, what is an issue with it, etc.. Nothing of this is
> covered.

This was addressed in an updated version of the patch sent on 11/6
which has since been incorporated.

>> > Reference to private tracker's RefID number
>> > is not enough.
>>
>> It's not private as I've tried to explain before.
>
> You said this, but you never provided any link to where it is published.
> Could you?

It's on the IBTA spec page.

-- Hal

>
> Sasha
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html