[PATCH] opensm - use C99 transportable data type for pointer storage

[PATCH] opensm - use C99 transportable data type for pointer storage

[Stan C. Smith]

In order to skip the #ifndef __WIN__ around #include <stdint.h>, inttypes.h was used.
'inttypes.h' includes stdint.h and exists in the WinOF svn tree.
OFED opensm builds without problems on EL 5.3.

Signed-off-by: stan smith <stan.smith@intel.com>

diff --git a/opensm/include/opensm/st.h b/opensm/include/opensm/st.h
index 30cc308..ad6c289 100644
--- a/opensm/include/opensm/st.h
+++ b/opensm/include/opensm/st.h
@@ -39,6 +39,7 @@
 #define ST_INCLUDED
 
 #include <stdlib.h>
+#include <inttypes.h>
 
 #ifdef __cplusplus
 #  define BEGIN_C_DECLS extern "C" {
@@ -49,7 +50,7 @@
 #endif				/* __cplusplus */
 
 BEGIN_C_DECLS
-#define st_ptr_t unsigned long
+#define st_ptr_t uintptr_t
 typedef st_ptr_t st_data_t;
 
 #define ST_DATA_T_DEFINED

RE: [PATCH] opensm - use C99 transportable data type for pointer storage

[Smith, Stan]

Hello,
  Can you help me understand why this patch always seems to fall into a black hole with no feedback?

Thank you,

Stan.


Stan C. Smith wrote:
> In order to skip the #ifndef __WIN__ around #include <stdint.h>,
> inttypes.h was used. 'inttypes.h' includes stdint.h and exists in the
> WinOF svn tree.
> OFED opensm builds without problems on EL 5.3.
>
> Signed-off-by: stan smith <stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> diff --git a/opensm/include/opensm/st.h b/opensm/include/opensm/st.h
> index 30cc308..ad6c289 100644
> --- a/opensm/include/opensm/st.h
> +++ b/opensm/include/opensm/st.h
> @@ -39,6 +39,7 @@
>  #define ST_INCLUDED
>
>  #include <stdlib.h>
> +#include <inttypes.h>
>
>  #ifdef __cplusplus
>  #  define BEGIN_C_DECLS extern "C" {
> @@ -49,7 +50,7 @@
>  #endif                               /* __cplusplus */
>
>  BEGIN_C_DECLS
> -#define st_ptr_t unsigned long
> +#define st_ptr_t uintptr_t
>  typedef st_ptr_t st_data_t;
>
>  #define ST_DATA_T_DEFINED

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [ofw] RE: [PATCH] opensm - use C99 transportable data type forpointer storage

[Leonid Keller]

Did you send it before morning coffee or after ?  :)

Maybe, because it seems obvious. 
All are agree with the elimination of unnecessary #ifndef's.
As to me, go ahead, commit it.

> -----Original Message-----
> From: ofw-bounces-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org 
> [mailto:ofw-bounces-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org] On Behalf Of Smith, Stan
> Sent: Thursday, November 12, 2009 7:32 PM
> To: 'Sasha Khapyorsky'
> Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; ofw-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org
> Subject: [ofw] RE: [PATCH] opensm - use C99 transportable 
> data type forpointer storage
> 
> Hello,
>   Can you help me understand why this patch always seems to 
> fall into a black hole with no feedback?
> 
> Thank you,
> 
> Stan.
> 
> 
> Stan C. Smith wrote:
> > In order to skip the #ifndef __WIN__ around #include <stdint.h>, 
> > inttypes.h was used. 'inttypes.h' includes stdint.h and 
> exists in the 
> > WinOF svn tree.
> > OFED opensm builds without problems on EL 5.3.
> >
> > Signed-off-by: stan smith <stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >
> > diff --git a/opensm/include/opensm/st.h 
> b/opensm/include/opensm/st.h 
> > index 30cc308..ad6c289 100644
> > --- a/opensm/include/opensm/st.h
> > +++ b/opensm/include/opensm/st.h
> > @@ -39,6 +39,7 @@
> >  #define ST_INCLUDED
> >
> >  #include <stdlib.h>
> > +#include <inttypes.h>
> >
> >  #ifdef __cplusplus
> >  #  define BEGIN_C_DECLS extern "C" {
> > @@ -49,7 +50,7 @@
> >  #endif                               /* __cplusplus */
> >
> >  BEGIN_C_DECLS
> > -#define st_ptr_t unsigned long
> > +#define st_ptr_t uintptr_t
> >  typedef st_ptr_t st_data_t;
> >
> >  #define ST_DATA_T_DEFINED
> 
> _______________________________________________
> ofw mailing list
> ofw-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [ofw] RE: [PATCH] opensm - use C99 transportable data type forpointer storage

[Sean Hefty]

>Did you send it before morning coffee or after ?  :)
>
>Maybe, because it seems obvious.
>All are agree with the elimination of unnecessary #ifndef's.
>As to me, go ahead, commit it.

It needs to be merged into the mgmt.git tree.

>> >  #include <stdlib.h>
>> > +#include <inttypes.h>
>> >
>> >  #ifdef __cplusplus
>> >  #  define BEGIN_C_DECLS extern "C" {
>> > @@ -49,7 +50,7 @@
>> >  #endif                               /* __cplusplus */
>> >
>> >  BEGIN_C_DECLS
>> > -#define st_ptr_t unsigned long
>> > +#define st_ptr_t uintptr_t

Does anyone know the reason for st_ptr_t at all?  Why not use uintptr_t
everywhere and avoid the define?


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: RE: [PATCH] opensm - use C99 transportable data type forpointer storage

[Smith, Stan]

Hefty, Sean wrote:
>> Did you send it before morning coffee or after ?  :)
>>
>> Maybe, because it seems obvious.
>> All are agree with the elimination of unnecessary #ifndef's.
>> As to me, go ahead, commit it.
>
> It needs to be merged into the mgmt.git tree.
>
>>>>  #include <stdlib.h>
>>>> +#include <inttypes.h>
>>>>
>>>>  #ifdef __cplusplus
>>>>  #  define BEGIN_C_DECLS extern "C" {
>>>> @@ -49,7 +50,7 @@
>>>>  #endif                               /* __cplusplus */
>>>>
>>>>  BEGIN_C_DECLS
>>>> -#define st_ptr_t unsigned long
>>>> +#define st_ptr_t uintptr_t
>
> Does anyone know the reason for st_ptr_t at all?  Why not use
> uintptr_t everywhere and avoid the define?

This is a good question. I avoided the issue due to the fact this patch has been submitted before with no feedback so KIS is the game plan for now.

Once the uintptr_t concept has been accepted, then a 2nd step would be to replace st_ptr_t with uintptr_t and remove the #define.

Re: [PATCH] opensm - use C99 transportable data type for pointer storage

[Sasha Khapyorsky]

On 09:32 Thu 12 Nov     , Smith, Stan wrote:
> Hello,
>   Can you help me understand why this patch always seems to fall into a black hole with no feedback?

Bad luck and my wishes to understand what is going on there. However the
second is less critical in this particular case - I can do it after
applying the patch.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] opensm - use C99 transportable data type for pointer storage

[Sasha Khapyorsky]

On 17:48 Mon 09 Nov     , Stan C. Smith wrote:
> 
> In order to skip the #ifndef __WIN__ around #include <stdint.h>, inttypes.h was used.
> 'inttypes.h' includes stdint.h and exists in the WinOF svn tree.
> OFED opensm builds without problems on EL 5.3.
> 
> Signed-off-by: stan smith <stan.smith@intel.com>

Applied. Thanks.

Sasha