[infiniband-diags] [PATCH 1/2] consistently type lids and lmcs libibnetdisc

[infiniband-diags] [PATCH 1/2] consistently type lids and lmcs libibnetdisc

[Al Chu]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

Hey Sasha,

The ibnd_port_t lid and lmc are typed uint16_t/uint8_t, but the
ibnd_node_t smalid and smalmc are typed int/int.  This patch turns the
ints into uint16_t/uint8_t.

Naturally, we can do the opposite, but it should be consistent one way
or the other.

Al

-- 
Albert Chu
chu11-i2BcT+NCU+M@public.gmane.org
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory

[-- Attachment #2: 0001-consistently-type-lids-and-lmcs-libibnetdisc.patch --]
[-- Type: text/plain, Size: 933 bytes --]

From: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>
Date: Thu, 5 Nov 2009 14:58:11 -0800
Subject: [PATCH] consistently type lids and lmcs libibnetdisc


Signed-off-by: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>
---
 .../libibnetdisc/include/infiniband/ibnetdisc.h    |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/infiniband-diags/libibnetdisc/include/infiniband/ibnetdisc.h b/infiniband-diags/libibnetdisc/include/infiniband/ibnetdisc.h
index 37de342..e8ceff7 100644
--- a/infiniband-diags/libibnetdisc/include/infiniband/ibnetdisc.h
+++ b/infiniband-diags/libibnetdisc/include/infiniband/ibnetdisc.h
@@ -49,8 +49,8 @@ typedef struct ibnd_node {
 	struct ibnd_node *next;	/* all node list in fabric */
 
 	ib_portid_t path_portid;	/* path from "from_node" */
-	int smalid;
-	int smalmc;
+	uint16_t smalid;
+	uint8_t smalmc;
 
 	/* quick cache of switchinfo below */
 	int smaenhsp0;
-- 
1.5.4.5

Re: [infiniband-diags] [PATCH 1/2] consistently type lids and lmcs libibnetdisc

[Sasha Khapyorsky]

On 10:14 Fri 06 Nov     , Al Chu wrote:
> Hey Sasha,
> 
> The ibnd_port_t lid and lmc are typed uint16_t/uint8_t, but the
> ibnd_node_t smalid and smalmc are typed int/int.  This patch turns the
> ints into uint16_t/uint8_t.
> 
> Naturally, we can do the opposite, but it should be consistent one way
> or the other.
> 
> Al
> 
> -- 
> Albert Chu
> chu11-i2BcT+NCU+M@public.gmane.org
> Computer Scientist
> High Performance Systems Division
> Lawrence Livermore National Laboratory

> From: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>
> Date: Thu, 5 Nov 2009 14:58:11 -0800
> Subject: [PATCH] consistently type lids and lmcs libibnetdisc
> 
> 
> Signed-off-by: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>

Applied. Thanks.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html