From: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: Sammy Wilborn <samm-sJ/iWh9BUns@public.gmane.org>
Cc: Michael Reed <mdr-sJ/iWh9BUns@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jeremy Higdon <jeremy-sJ/iWh9BUns@public.gmane.org>
Subject: Re: [PATCH 1/1] opensm/main.c: opensm cannot be killed while asking for port guid
Date: Fri, 13 Nov 2009 15:03:08 +0200 [thread overview]
Message-ID: <20091113130308.GM7192@me> (raw)
In-Reply-To: <20091112192422.E16537-NOE8RvUWeBY4qRZnexmlh9BPR1lH4CV8@public.gmane.org>
On 19:24 Thu 12 Nov , Sammy Wilborn wrote:
> > > - printf("\nError: Lame choice!\n");
> > > + printf("\nError: Please try again.\n");
> >
> > "Try again" is good, but it is useful to provide a reason too, so let's
> > do it even more "professional":
> >
> > printf("\nError: Lame choice! Please try again.\n");
>
> How about the following?
>
> printf("\nError: Invalid choice! Please try again.\n");
This works too. Would you care about the patch?
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-11-13 13:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 18:41 [PATCH 1/1] opensm/main.c: opensm cannot be killed while asking for port guid Michael Reed
[not found] ` <4AF46DEB.7090105-sJ/iWh9BUns@public.gmane.org>
2009-11-13 2:55 ` Sasha Khapyorsky
2009-11-13 3:24 ` Sammy Wilborn
[not found] ` <20091112192422.E16537-NOE8RvUWeBY4qRZnexmlh9BPR1lH4CV8@public.gmane.org>
2009-11-13 13:03 ` Sasha Khapyorsky [this message]
2009-11-13 18:55 ` Michael Reed
[not found] ` <4AFDAB9F.6020900-sJ/iWh9BUns@public.gmane.org>
2009-11-13 20:04 ` Sasha Khapyorsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091113130308.GM7192@me \
--to=sashak-smomgflxvozwk0htik3j/w@public.gmane.org \
--cc=jeremy-sJ/iWh9BUns@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mdr-sJ/iWh9BUns@public.gmane.org \
--cc=samm-sJ/iWh9BUns@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox