From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
Cc: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
frank zago
<fzago-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: ib_post_send in drivers
Date: Sat, 21 Nov 2009 14:52:52 -0700 [thread overview]
Message-ID: <20091121215252.GE1966@obsidianresearch.com> (raw)
In-Reply-To: <e2e108260911211237j2b9fd96cn3df78fe5c59fdc5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Sat, Nov 21, 2009 at 09:37:29PM +0100, Bart Van Assche wrote:
> It would be more useful IMHO if ib_post_send() would not
> post any WR instead of posting part of the WR's passed to
> ib_post_send() when the 'queue full' condition is hit. Note: SRPT uses
> a single SRQ per HCA, even when multiple SRP connections are active
> for the same HCA.
Well, yes, this is useful, but the way verbs is kinda designed, it
isn't the verbs layer that worries about that. If your app cannot
handle a partial send then it must track the SQ availability on its
own and never cause the SQ to overflow. This is what SRP initiator
does, for instance.
If you are keeping track, and you get ENOMEM then it is a bug.
A fair criticism is that verbs doesn't have APIs to export the various
Q availabilities - but I think ib_post_send is fine for its intended
role.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-11-21 21:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 16:16 ib_post_send in drivers frank zago
[not found] ` <4B06C0EA.2070501-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2009-11-20 19:26 ` Bart Van Assche
[not found] ` <e2e108260911201126o5233ea3v94163083fe3d26fc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-11-20 20:08 ` Sean Hefty
[not found] ` <E102E8F5252B43318544B660CF6B78F7-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2009-11-21 11:17 ` Bart Van Assche
[not found] ` <e2e108260911210317t323adfe0k4aa3e821d3a1c63c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-11-21 20:01 ` Jason Gunthorpe
[not found] ` <20091121200128.GD1966-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2009-11-21 20:37 ` Bart Van Assche
[not found] ` <e2e108260911211237j2b9fd96cn3df78fe5c59fdc5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-11-21 21:52 ` Jason Gunthorpe [this message]
2009-11-23 19:09 ` Roland Dreier
2009-11-23 19:02 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091121215252.GE1966@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=bvanassche-HInyCGIudOg@public.gmane.org \
--cc=fzago-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox