From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 9/9] ib/addr: fix ipv6 routing lookup
Date: Mon, 23 Nov 2009 23:56:58 -0700 [thread overview]
Message-ID: <20091124065658.GH1966@obsidianresearch.com> (raw)
In-Reply-To: <89DF931E4E7549858A9BF7A31912F2F7-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
On Mon, Nov 23, 2009 at 07:43:34PM -0800, Sean Hefty wrote:
> >The sin6_scope_id must be ignored in all cases except LL
> >addresses. Fixing this will break the path that sets the bound_dev_if
> >starting from rdma_resolve_addr. This is why my version was setting
> >bound_dev_if directly in rdma_resolve_addr.
> >
> >Did you change it to be like this because you found something wrong
> >with the way things were in my big patch?
>
> I was wanting to have all of the code paths go through rdma_bind_addr(), with
> source address checks there to things as easy to follow as possible.
OK. Then I'll send a patch to do it the other way, processing
sin6_scope_id for the non-link-local case is worth fixing.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-11-24 6:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 0:12 [PATCH 9/9] ib/addr: fix ipv6 routing lookup Sean Hefty
[not found] ` <2449CF17D7E94FCBA643A743473246A5-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2009-11-18 16:52 ` [PATCH 9/9 v2] " Sean Hefty
[not found] ` <B596269C5991406FA7EA473D383667F8-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2009-11-19 16:46 ` [PATCH 9/9 v3] " Sean Hefty
2009-11-23 19:48 ` [PATCH 9/9] " Jason Gunthorpe
[not found] ` <20091123194847.GL6188-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2009-11-23 22:07 ` Sean Hefty
[not found] ` <913F7AE25239487A9AF368E608F30A34-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2009-11-23 22:26 ` Jason Gunthorpe
[not found] ` <20091123222652.GM6188-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2009-11-24 3:43 ` Sean Hefty
[not found] ` <89DF931E4E7549858A9BF7A31912F2F7-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2009-11-24 6:56 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091124065658.GH1966@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox