From: Hal Rosenstock <hnrose-Wuw85uim5zDR7s880joybQ@public.gmane.org>
To: sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] opensm/osm_trap_rcv.c: No need for heavy sweep when trap 144 indicates just NodeDescription change
Date: Tue, 1 Dec 2009 08:12:15 -0500 [thread overview]
Message-ID: <20091201131215.GA12753@comcast.net> (raw)
For trap 144s which indicate NodeDescription changed, there is no need for
a heavy sweep if that is the only change indicated by the trap. Determine that
by checking that there are no other change flags set and that the
capability mask is unchanged. Still sweep if this is not the case (there
is some other change).
Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
diff --git a/opensm/opensm/osm_trap_rcv.c b/opensm/opensm/osm_trap_rcv.c
index 52f8832..9024a1f 100644
--- a/opensm/opensm/osm_trap_rcv.c
+++ b/opensm/opensm/osm_trap_rcv.c
@@ -509,6 +509,9 @@ static void trap_rcv_process_request(IN osm_sm_t * sm,
CL_PLOCK_ACQUIRE(sm->p_lock);
osm_req_get_node_desc(sm, p_physp);
CL_PLOCK_RELEASE(sm->p_lock);
+ if (!(p_ntci->data_details.ntc_144.change_flgs & ~TRAP_144_MASK_NODE_DESCRIPTION_CHANGE) &&
+ p_ntci->data_details.ntc_144.new_cap_mask == p_physp->port_info.capability_mask)
+ goto check_report;
} else
OSM_LOG(sm->p_log, OSM_LOG_ERROR,
"ERR 3812: No physical port found for "
@@ -547,6 +550,7 @@ check_sweep:
if (physp_change_trap == TRUE)
goto Exit;
+check_report:
/* Add a call to osm_report_notice */
/* We are going to report the notice - so need to fix the IssuerGID
accordingly. See IBA 1.2 p.739 or IBA 1.1 p.653 for details. */
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
reply other threads:[~2009-12-01 13:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091201131215.GA12753@comcast.net \
--to=hnrose-wuw85uim5zdr7s880joybq@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox