* [PATCH] mlx4_core: Cleanup bug in __mlx4_init_one()
@ 2009-12-09 15:22 Eli Cohen
2009-12-09 22:35 ` Roland Dreier
0 siblings, 1 reply; 3+ messages in thread
From: Eli Cohen @ 2009-12-09 15:22 UTC (permalink / raw)
To: Roland Dreier; +Cc: Linux RDMA list, ewg
If mlx4_init_port_info() fails, cleanup the initialized ports only.
Signed-off-by: Eli Cohen <eli-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
---
drivers/net/mlx4/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/mlx4/main.c b/drivers/net/mlx4/main.c
index 6f5a3cf..0c868c9 100644
--- a/drivers/net/mlx4/main.c
+++ b/drivers/net/mlx4/main.c
@@ -1294,7 +1294,7 @@ static int __mlx4_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
return 0;
err_port:
- for (port = 1; port <= dev->caps.num_ports; port++)
+ for (--port; port >= 1; --port)
mlx4_cleanup_port_info(&priv->port[port]);
mlx4_cleanup_counters_table(dev);
--
1.6.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mlx4_core: Cleanup bug in __mlx4_init_one()
2009-12-09 15:22 [PATCH] mlx4_core: Cleanup bug in __mlx4_init_one() Eli Cohen
@ 2009-12-09 22:35 ` Roland Dreier
[not found] ` <adatyvzpyhl.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Roland Dreier @ 2009-12-09 22:35 UTC (permalink / raw)
To: Eli Cohen; +Cc: Linux RDMA list, ewg
Looks like a valid fix but your patch doesn't apply. I don't seem to
have mlx4_cleanup_counters_table() in my tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Re: [PATCH] mlx4_core: Cleanup bug in __mlx4_init_one()
[not found] ` <adatyvzpyhl.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
@ 2009-12-09 22:40 ` Eli Cohen
0 siblings, 0 replies; 3+ messages in thread
From: Eli Cohen @ 2009-12-09 22:40 UTC (permalink / raw)
To: Roland Dreier; +Cc: Linux RDMA list, Eli Cohen, ewg
On Wed, Dec 09, 2009 at 02:35:18PM -0800, Roland Dreier wrote:
> Looks like a valid fix but your patch doesn't apply. I don't seem to
> have mlx4_cleanup_counters_table() in my tree.
I noticed that already. I'll send a new patch in my next working day.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-09 22:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-09 15:22 [PATCH] mlx4_core: Cleanup bug in __mlx4_init_one() Eli Cohen
2009-12-09 22:35 ` Roland Dreier
[not found] ` <adatyvzpyhl.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2009-12-09 22:40 ` Eli Cohen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox