From: Hal Rosenstock <hnrose-Wuw85uim5zDR7s880joybQ@public.gmane.org>
To: sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
elid-smomgflXvOZWk0Htik3J/w@public.gmane.org,
celine.bourde-6ktuUTfB/bM@public.gmane.org
Subject: [PATCH] opensm/osm_sm_mad_ctrl.c: In sm_mad_ctrl_send_err_cb, revert setting of init failure on QoS initialization failures
Date: Thu, 24 Dec 2009 06:20:36 -0500 [thread overview]
Message-ID: <20091224112036.GA32559@comcast.net> (raw)
opensm/osm_sm_mad_ctrl.c: In sm_mad_ctrl_send_err_cb, revert setting of init failure on QoS attribute initialization failures
Revert the QoS related part of commit 254c2ef34fa0f475a93a63d805582bdd2efdeace
There are unexplained cases of status 0x1c that have been observed
for SL to VL mapping table setting as documented in "Re: qos on service-id"
http://article.gmane.org/gmane.linux.drivers.rdma/1464
A subsequent patch will reintroduce this checking based on an additional
option which will default to not do this.
Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
diff --git a/opensm/opensm/osm_sm_mad_ctrl.c b/opensm/opensm/osm_sm_mad_ctrl.c
index 3ae1eb6..086f71c 100644
--- a/opensm/opensm/osm_sm_mad_ctrl.c
+++ b/opensm/opensm/osm_sm_mad_ctrl.c
@@ -729,9 +729,7 @@ static void sm_mad_ctrl_send_err_cb(IN void *context, IN osm_madw_t * p_madw)
p_smp->attr_id == IB_MAD_ATTR_MCAST_FWD_TBL ||
p_smp->attr_id == IB_MAD_ATTR_SWITCH_INFO ||
p_smp->attr_id == IB_MAD_ATTR_LIN_FWD_TBL ||
- p_smp->attr_id == IB_MAD_ATTR_P_KEY_TABLE ||
- p_smp->attr_id == IB_MAD_ATTR_SLVL_TABLE ||
- p_smp->attr_id == IB_MAD_ATTR_VL_ARBITRATION)) {
+ p_smp->attr_id == IB_MAD_ATTR_P_KEY_TABLE)) {
OSM_LOG(p_ctrl->p_log, OSM_LOG_ERROR, "ERR 3119: "
"Set method failed for attribute 0x%X (%s)\n",
cl_ntoh16(p_smp->attr_id),
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2009-12-24 11:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-24 11:20 Hal Rosenstock [this message]
[not found] ` <20091224112036.GA32559-Wuw85uim5zDR7s880joybQ@public.gmane.org>
2009-12-24 12:37 ` [PATCH] opensm/osm_sm_mad_ctrl.c: In sm_mad_ctrl_send_err_cb, revert setting of init failure on QoS initialization failures Sasha Khapyorsky
2009-12-24 12:56 ` Sasha Khapyorsky
2009-12-28 16:08 ` Hal Rosenstock
[not found] ` <f0e08f230912280808s31c09d46ndeb3586007507e40-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-29 14:54 ` Sasha Khapyorsky
2009-12-30 16:14 ` Hal Rosenstock
[not found] ` <f0e08f230912300814h1c6ad213j2b8a343403e2744e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-30 19:37 ` Sasha Khapyorsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091224112036.GA32559@comcast.net \
--to=hnrose-wuw85uim5zdr7s880joybq@public.gmane.org \
--cc=celine.bourde-6ktuUTfB/bM@public.gmane.org \
--cc=elid-smomgflXvOZWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox