Re: [PATCHv3] opensm: Add support for optimized SLtoVLMappingTable programming

Sasha Khapyorsky
2010-01-25T17:41:13Z

On 07:26 Sat 23 Jan , Hal Rosenstock wrote:
> >
> > Yes, and how is this different from the original patch?
>
> The original patch didn't do this but missed accounting for the switch
> port 0 configuration.

I cannot understand. What do you mean?

> > Remember, that there is a different configuration for switch's port 0
> > (needed or not - this is another question), so we must to take it into
> > account.
>
> Yes but is there a need for this if they are the same and wildcarding
> is used ? That will save what seems to me to be an unneeded MAD
> request/response pair per switch.

This leads us to switch ports (0 and externals) QoS configuration
unification. Basically I have nothing against this, but this is not
actually related to this patch series. And should be done first as
completely separate change, then we can merge SL2VL setup too.

However, there is some related long time pended task - QoS policy and
QoS port parameters configurations merge. Keeping this in the mind I
would think that finally we will need ability to have "per-port" SL2VL
and VLArb configuration. We can take it into account even now.

Sasha