From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: 'Eli Cohen'
<eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
Or Gerlitz <ogerlitz-hKgKHo2Ms0FWk0Htik3J/w@public.gmane.org>,
Eli Cohen <eli-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>,
Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>,
Linux RDMA list
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCHv7 4/9] ib_core: RoCEE CMA device binding
Date: Thu, 7 Jan 2010 11:24:51 -0700 [thread overview]
Message-ID: <20100107182451.GD4664@obsidianresearch.com> (raw)
In-Reply-To: <1E5F6C57727E4A3BB737240D2D1942A4-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
On Thu, Jan 07, 2010 at 08:50:47AM -0800, Sean Hefty wrote:
> >> > + route->path_rec->hop_limit = 2;
> >>
> >
> >The reason is that ib_init_ah_from_path() will not set IB_AH_GRH for
> >hop_limit smaller then 2, and since that GRH is required in RoCEE, and
> >since this is specific to RoCEE, I put 2 to make pass this.
>
> A hop limit of 2 seems wrong though. Isn't there some change that
> could be made to ib_init_ah_from_path() that would work? It seems
> like the PR itself should indicate somehow whether the path is for
> IB or Ethernet. (Special LID values or some flag...)
I agree, on the wire the hop limit in the GRH should be 0 or 0xFF. 0
is preferred since there is no support for routing.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-01-07 18:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 10:32 [PATCHv7 4/9] ib_core: RoCEE CMA device binding Eli Cohen
2010-01-07 14:02 ` Or Gerlitz
[not found] ` <4B45E977.70805-hKgKHo2Ms0FWk0Htik3J/w@public.gmane.org>
2010-01-07 15:19 ` Eli Cohen
2010-01-07 16:50 ` Sean Hefty
[not found] ` <1E5F6C57727E4A3BB737240D2D1942A4-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2010-01-07 18:24 ` Jason Gunthorpe [this message]
[not found] ` <20100107182451.GD4664-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-01-11 10:54 ` Eli Cohen
2010-01-18 8:00 ` Or Gerlitz
2010-01-11 14:04 ` Hal Rosenstock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100107182451.GD4664@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=eli-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-hKgKHo2Ms0FWk0Htik3J/w@public.gmane.org \
--cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox