public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: Al Chu <chu11-i2BcT+NCU+M@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [infiniband-diags] [UPDATED PATCH] [3/3] support --load-cache in iblinkinfo and ibqueryerrors
Date: Sat, 16 Jan 2010 20:40:31 +0200	[thread overview]
Message-ID: <20100116184031.GW574@me> (raw)
In-Reply-To: <1263659117.14626.12.camel-RLKWKRZIcZkVVsCFsIUZTRy+HRzXvqW9@public.gmane.org>

On 08:25 Sat 16 Jan     , Al Chu wrote:
> > > @@ -317,6 +322,11 @@ int main(int argc, char **argv)
> > >  		mad_rpc_set_timeout(ibmad_port, ibd_timeout);
> > >  
> > >  	node_name_map = open_node_name_map(node_name_map_file);
> > > +	
> > > +	if (dr_path && load_cache_file) {
> > > +		fprintf(stderr, "Cannot specify cache and direct route path\n");
> > > +		exit(1);
> > > +	}
> > 
> > Why is this limitation needed really?
> 
> I spoke to Ira about it awhile ago.  I think what we decided was that
> while technically you can do a DR path, b/c you can load a cache from
> anywhere in the cluster, you won't know if the DR path is legal or
> correct at point A vs point B.  In contrast, the node_guid input is
> valid anywhere you are on the cluster.

But OTOH you have "from" field in the cache. Isn't it used to save an
original discovery point?

> I suppose we could just allow it and the user has to understand this
> fact??

First we need to decide about what this would mean - a path from an
original discovery point or path from a current one.

In any case I think that we can start with disabled direct path option
and re-enable later if it would be useful.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-01-16 18:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-15 18:23 [infiniband-diags] [UPDATED PATCH] [3/3] support --load-cache in iblinkinfo and ibqueryerrors Al Chu
     [not found] ` <1263579799.15172.168.camel-X2zTWyBD0EhliZ7u+bvwcg@public.gmane.org>
2010-01-16 14:28   ` Sasha Khapyorsky
2010-01-16 16:25     ` Al Chu
     [not found]       ` <1263659117.14626.12.camel-RLKWKRZIcZkVVsCFsIUZTRy+HRzXvqW9@public.gmane.org>
2010-01-16 18:40         ` Sasha Khapyorsky [this message]
2010-01-19  5:35     ` Al Chu
     [not found]       ` <1263879351.21443.13.camel-RLKWKRZIcZkVVsCFsIUZTRy+HRzXvqW9@public.gmane.org>
2010-01-19 13:50         ` Sasha Khapyorsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100116184031.GW574@me \
    --to=sashak-smomgflxvozwk0htik3j/w@public.gmane.org \
    --cc=chu11-i2BcT+NCU+M@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox