From: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] infiniband-diags/ibqueryerrors: Add support for optional PortRcvErrorDetails counter
Date: Sat, 16 Jan 2010 21:53:26 +0200 [thread overview]
Message-ID: <20100116195326.GZ574@me> (raw)
In-Reply-To: <f0e08f231001131210r669265fax870cfb4bbaf3c1d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 15:10 Wed 13 Jan , Hal Rosenstock wrote:
[snip]
> >> @@ -364,6 +375,10 @@ static void clear_port(ib_portid_t * portid, uint16_t cap_mask,
> >> performance_reset_via(pc, portid, port, mask, ibd_timeout,
> >> IB_GSI_PORT_XMIT_DISCARD_DETAILS,
> >> ibmad_port);
> >> + mask = 0x3F;
> >> + performance_reset_via(pc, portid, port, mask, ibd_timeout,
> >> + IB_GSI_PORT_RCV_ERROR_DETAILS,
> >> + ibmad_port);
> >
> > If 'mask' value is used unconditionally whouldn't it be simpler to just
> > write:
> >
> > performance_reset_via(pc, portid, port, 0x3f, ibd_timeout,
> > IB_GSI_PORT_RCV_ERROR_DETAILS,
> > ibmad_port);
> >
> > ?
>
> Yes and that comment also applies to the instance above this for xmit
> discard details reset.
Ok. Both patches are applied. Thanks.
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-01-16 19:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-31 19:10 [PATCH] infiniband-diags/ibqueryerrors: Add support for optional PortRcvErrorDetails counter Hal Rosenstock
[not found] ` <20091231191054.GA27874-Wuw85uim5zDR7s880joybQ@public.gmane.org>
2010-01-12 19:14 ` Sasha Khapyorsky
2010-01-13 20:10 ` Hal Rosenstock
[not found] ` <f0e08f231001131210r669265fax870cfb4bbaf3c1d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-01-16 19:53 ` Sasha Khapyorsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100116195326.GZ574@me \
--to=sashak-smomgflxvozwk0htik3j/w@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox