From: Bart Van Assche <bart.vanassche-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Reducing the number of IB interrupts caused by the SRP initiator
Date: Sun, 17 Jan 2010 20:08:16 +0100 [thread overview]
Message-ID: <201001172008.16461.bart.vanassche@gmail.com> (raw)
Hello,
Once I noticed that the SRP initiator triggers two IB interrupts per I/O (more
precise, per srp_queuecommand() call) I started looking at reducing the number
of IB interrupts. The patch below didn't help. Does this mean that the patch
below isn't complete or is this because of the hw driver used during the test
(mlx4) ?
Bart.
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
index 54c8fe2..1f674b8 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++ b/drivers/infiniband/ulp/srp/ib_srp.c
@@ -241,7 +241,7 @@ static int srp_create_target_ib(struct srp_target_port *target)
init_attr->cap.max_recv_wr = SRP_RQ_SIZE;
init_attr->cap.max_recv_sge = 1;
init_attr->cap.max_send_sge = 1;
- init_attr->sq_sig_type = IB_SIGNAL_ALL_WR;
+ init_attr->sq_sig_type = IB_SIGNAL_REQ_WR;
init_attr->qp_type = IB_QPT_RC;
init_attr->send_cq = target->cq;
init_attr->recv_cq = target->cq;
@@ -1001,7 +1001,8 @@ static int __srp_post_send(struct srp_target_port *target,
wr.sg_list = &list;
wr.num_sge = 1;
wr.opcode = IB_WR_SEND;
- wr.send_flags = IB_SEND_SIGNALED;
+ wr.send_flags = target->tx_head - target->tx_tail == SRP_SQ_SIZE - 1
+ ? IB_SEND_SIGNALED : 0;
ret = ib_post_send(target->qp, &wr, &bad_wr);
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2010-01-17 19:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-17 19:08 Bart Van Assche [this message]
[not found] ` <201001172008.16461.bart.vanassche-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-01-18 11:29 ` Reducing the number of IB interrupts caused by the SRP initiator Eli Cohen
[not found] ` <4e6a6b3c1001180329n25e4257brc55fa037b97e0d18-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-01-18 12:29 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001172008.16461.bart.vanassche@gmail.com \
--to=bart.vanassche-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox