[PATCH] opensm/osm_qos.c: Eliminate unneeded endport SL to VL setup

[PATCH] opensm/osm_qos.c: Eliminate unneeded endport SL to VL setup

[Hal Rosenstock]

when using optimized programming and it's supported by the switch

Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
diff --git a/opensm/opensm/osm_qos.c b/opensm/opensm/osm_qos.c
index 6bbbfa2..afa454f 100644
--- a/opensm/opensm/osm_qos.c
+++ b/opensm/opensm/osm_qos.c
@@ -305,6 +305,12 @@ int osm_qos_setup(osm_opensm_t * p_osm)
 			    (&p_node->sw->switch_info))
 				continue;
 
+			if (ib_switch_info_get_opt_sl2vlmapping(&p_node->sw->switch_info) &&
+			    p_osm->sm.p_subn->opt.use_optimized_slvl &&
+			    !memcmp(&swe_config.sl2vl, &sw0_config.sl2vl,
+				    sizeof(swe_config.sl2vl)))
+				continue;
+
 			cfg = &sw0_config;
 		} else if (osm_node_get_type(p_node) == IB_NODE_TYPE_ROUTER)
 			cfg = &rtr_config;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] opensm/osm_qos.c: Eliminate unneeded endport SL to VL setup

[Sasha Khapyorsky]

Hi Hal,

On 08:29 Mon 25 Jan     , Hal Rosenstock wrote:
> 
> when using optimized programming and it's supported by the switch
> 
> Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> diff --git a/opensm/opensm/osm_qos.c b/opensm/opensm/osm_qos.c
> index 6bbbfa2..afa454f 100644
> --- a/opensm/opensm/osm_qos.c
> +++ b/opensm/opensm/osm_qos.c
> @@ -305,6 +305,12 @@ int osm_qos_setup(osm_opensm_t * p_osm)
>  			    (&p_node->sw->switch_info))
>  				continue;
>  
> +			if (ib_switch_info_get_opt_sl2vlmapping(&p_node->sw->switch_info) &&
> +			    p_osm->sm.p_subn->opt.use_optimized_slvl &&
> +			    !memcmp(&swe_config.sl2vl, &sw0_config.sl2vl,
> +				    sizeof(swe_config.sl2vl)))
> +				continue;
> +

But then exports sl2vl tables setup loop should be changed starting from
port '0' (not '1'), right?

Sasha

>  			cfg = &sw0_config;
>  		} else if (osm_node_get_type(p_node) == IB_NODE_TYPE_ROUTER)
>  			cfg = &rtr_config;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] opensm/osm_qos.c: Eliminate unneeded endport SL to VL setup

[Hal Rosenstock]

Hi Sasha,

On Mon, Jan 25, 2010 at 12:46 PM, Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org> wrote:
> Hi Hal,
>
> On 08:29 Mon 25 Jan     , Hal Rosenstock wrote:
>>
>> when using optimized programming and it's supported by the switch
>>
>> Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>> diff --git a/opensm/opensm/osm_qos.c b/opensm/opensm/osm_qos.c
>> index 6bbbfa2..afa454f 100644
>> --- a/opensm/opensm/osm_qos.c
>> +++ b/opensm/opensm/osm_qos.c
>> @@ -305,6 +305,12 @@ int osm_qos_setup(osm_opensm_t * p_osm)
>>                           (&p_node->sw->switch_info))
>>                                continue;
>>
>> +                     if (ib_switch_info_get_opt_sl2vlmapping(&p_node->sw->switch_info) &&
>> +                         p_osm->sm.p_subn->opt.use_optimized_slvl &&
>> +                         !memcmp(&swe_config.sl2vl, &sw0_config.sl2vl,
>> +                                 sizeof(swe_config.sl2vl)))
>> +                             continue;
>> +
>
> But then exports sl2vl tables setup loop should be changed starting from
> port '0' (not '1'), right?

Isn't it just that vlarb needs to be pushed for port 0 in that case
(and not the sl2vl) ? Patch to follow.

-- Hal

> Sasha
>
>>                       cfg = &sw0_config;
>>               } else if (osm_node_get_type(p_node) == IB_NODE_TYPE_ROUTER)
>>                       cfg = &rtr_config;
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html