[PATCH] opensm/osm_sa.{c,h}: osm_sa_db_file_dump() return values

[PATCH] opensm/osm_sa.{c,h}: osm_sa_db_file_dump() return values

[Yevgeny Kliteynik]

Since osm_sa_db_file_dump() doesn't have to actually dump
SA DB, reflecting this in the function return values.

Function returns 0 if the SA DB was actually dumped,
>0 if there was no need to dump the SA DB and <0 if
some error occurred.

Signed-off-by: Yevgeny Kliteynik <kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
---
 opensm/include/opensm/osm_sa.h |    4 +++-
 opensm/opensm/osm_sa.c         |    2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/opensm/include/opensm/osm_sa.h b/opensm/include/opensm/osm_sa.h
index 9229d1a..d516310 100644
--- a/opensm/include/opensm/osm_sa.h
+++ b/opensm/include/opensm/osm_sa.h
@@ -436,7 +436,9 @@ int osm_sa_db_file_dump(struct osm_opensm *p_osm);
 *		[in] Pointer to an osm_opensm_t object.
 *
 * RETURN VALUES
-*	None
+*	 0 if the SA DB was actually dumped
+*	>0 if there was no need to dump the SA DB
+*	<0 if some error occurred.
 *
 *********/

diff --git a/opensm/opensm/osm_sa.c b/opensm/opensm/osm_sa.c
index 0d203ad..3473e4c 100644
--- a/opensm/opensm/osm_sa.c
+++ b/opensm/opensm/osm_sa.c
@@ -704,7 +704,7 @@ static void sa_dump_all_sa(osm_opensm_t * p_osm, FILE * file)

 int osm_sa_db_file_dump(osm_opensm_t * p_osm)
 {
-	int res = 0;
+	int res = 1;
 	if (p_osm->sa.dirty) {
 		res = opensm_dump_to_file(
 			p_osm, "opensm-sa.dump", sa_dump_all_sa);
-- 
1.5.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] opensm/osm_sa.{c,h}: osm_sa_db_file_dump() return values

[Sasha Khapyorsky]

On 17:54 Thu 21 Jan     , Yevgeny Kliteynik wrote:
> Since osm_sa_db_file_dump() doesn't have to actually dump
> SA DB, reflecting this in the function return values.
> 
> Function returns 0 if the SA DB was actually dumped,
> >0 if there was no need to dump the SA DB and <0 if
> some error occurred.
> 
> Signed-off-by: Yevgeny Kliteynik <kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>

Applied. Thanks.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html