linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@hp.com>
To: rdreier@cisco.com
Cc: linux-rdma@vger.kernel.org, justin.chen@hp.com,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 15/18] IB/ucm: use stack variable 'base' in ib_ucm_add_one
Date: Tue, 02 Feb 2010 12:09:00 -0700	[thread overview]
Message-ID: <20100202190900.28217.53919.stgit@bob.kio> (raw)
In-Reply-To: <20100202185235.28217.64521.stgit@bob.kio>

This change is not useful by itself, but sets us up for a future change
that allows us to support more than IB_UCM_MAX_DEVICES.

Signed-off-by: Alex Chiang <achiang@hp.com>
---

 drivers/infiniband/core/ucm.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/infiniband/core/ucm.c b/drivers/infiniband/core/ucm.c
index 7ff3300..06c50d8 100644
--- a/drivers/infiniband/core/ucm.c
+++ b/drivers/infiniband/core/ucm.c
@@ -1240,6 +1240,7 @@ static DEVICE_ATTR(ibdev, S_IRUGO, show_ibdev, NULL);
 static void ib_ucm_add_one(struct ib_device *device)
 {
 	int devnum;
+	dev_t base;
 	struct ib_ucm_device *ucm_dev;
 
 	if (!device->alloc_ucontext ||
@@ -1257,12 +1258,13 @@ static void ib_ucm_add_one(struct ib_device *device)
 		goto err;
 
 	ucm_dev->devnum = devnum;
+	base = devnum + IB_UCM_BASE_DEV;
 	set_bit(devnum, dev_map);
 
 	cdev_init(&ucm_dev->cdev, &ucm_fops);
 	ucm_dev->cdev.owner = THIS_MODULE;
 	kobject_set_name(&ucm_dev->cdev.kobj, "ucm%d", ucm_dev->devnum);
-	if (cdev_add(&ucm_dev->cdev, IB_UCM_BASE_DEV + devnum, 1))
+	if (cdev_add(&ucm_dev->cdev, base, 1))
 		goto err;
 
 	ucm_dev->dev.class = &cm_class;

  parent reply	other threads:[~2010-02-02 19:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-02 19:07 [PATCH v2 00/18] Increase maximum number of Infiniband HCAs per system Alex Chiang
2010-02-02 19:07 ` [PATCH v2 01/18] IB/uverbs: convert *cdev to cdev in struct ib_uverbs_device Alex Chiang
2010-02-02 19:07 ` [PATCH v2 03/18] IB/uverbs: use stack variable 'devnum' in ib_uverbs_add_one Alex Chiang
2010-02-02 19:08 ` [PATCH v2 05/18] IB/uverbs: increase maximum devices supported Alex Chiang
2010-02-02 19:08 ` [PATCH v2 08/18] IB/umad: convert cdev pointers to embedded structs in struct ib_umad_port Alex Chiang
2010-02-02 19:08 ` [PATCH v2 10/18] IB/umad: use stack variable 'devnum' in ib_umad_init_port Alex Chiang
2010-02-02 19:08 ` [PATCH v2 11/18] IB/umad: use stack variable 'base' " Alex Chiang
2010-02-02 19:08 ` [PATCH v2 12/18] IB/umad: increase maximum devices supported Alex Chiang
     [not found] ` <20100202185235.28217.64521.stgit-tBlMHHroXgg@public.gmane.org>
2010-02-02 19:07   ` [PATCH v2 02/18] IB/uverbs: remove dev_table Alex Chiang
2010-02-02 19:08   ` [PATCH v2 04/18] IB/uverbs: use stack variable 'base' in ib_uverbs_add_one Alex Chiang
2010-02-02 19:08   ` [PATCH v2 06/18] IB/uverbs: pack struct ib_uverbs_event_file tighter Alex Chiang
2010-02-02 19:08   ` [PATCH v2 07/18] IB/uverbs: whitespace cleanup Alex Chiang
2010-02-02 19:08   ` [PATCH v2 09/18] IB/umad: remove port_table[] Alex Chiang
2010-02-02 19:08   ` [PATCH v2 13/18] IB/umad: clean whitespace Alex Chiang
2010-02-02 19:08   ` [PATCH v2 14/18] IB/ucm: use stack variable 'devnum' in ib_ucm_add_one Alex Chiang
2010-02-02 19:09   ` [PATCH v2 16/18] IB/ucm: increase maximum devices supported Alex Chiang
2010-02-02 19:09   ` [PATCH v2 17/18] IB/ucm: clean whitespace errors Alex Chiang
2010-02-02 19:09   ` [PATCH v2 18/18] IB/core: pack struct ib_device a little tighter Alex Chiang
     [not found]     ` <20100202190916.28217.90954.stgit-tBlMHHroXgg@public.gmane.org>
2010-02-24 18:24       ` Roland Dreier
2010-02-02 19:09 ` Alex Chiang [this message]
2010-02-08 21:30 ` [PATCH v2 00/18] Increase maximum number of Infiniband HCAs per system Alex Chiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100202190900.28217.53919.stgit@bob.kio \
    --to=achiang@hp.com \
    --cc=justin.chen@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).