Re: [PATCHv8 07/11] ib_core: Add API to support IBoE from userspace

Roland Dreier
2010-05-13T19:18:23Z

> Basically, what I want to understand is why does this change make sense?
>
> @@ -1139,6 +1139,10 @@ struct ib_device {
> struct ib_grh *in_grh,
> struct ib_mad *in_mad,
> struct ib_mad *out_mad);
> + int (*get_eth_l2_addr)(struct ib_device *device,
> u8 port,
> + union ib_gid *dgid, int
> sgid_idx,
> + u8 *mac, u16 *vlan_id, u8
> *tagged);
> +

Yes, that was pretty much my original question. Why do we have a verb
for userspace to call a device-specific method to do the mapping? The
layering seems wrong somewhere if we have a generic verb to do this
mapping, but then put the mapping in device-specific code.

- R.
--
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to: