From: Arthur Kepner <akepner-sJ/iWh9BUns@public.gmane.org>
To: Ralph Campbell <ralph.campbell-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>
Cc: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>,
linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] IB/ipoib: fix dangling pointer references to ipoib_neigh and ipoib_path
Date: Thu, 25 Feb 2010 12:03:57 -0800 [thread overview]
Message-ID: <20100225200357.GW29938@sgi.com> (raw)
In-Reply-To: <1267126142.30294.25.camel-/vjeY7uYZjrPXfVEPVhPGq6RkeBMCJyt@public.gmane.org>
On Thu, Feb 25, 2010 at 11:29:02AM -0800, Ralph Campbell wrote:
> ....
I haven't looked carefully at the whole patch, but this bit
looks wrong:
> @@ -848,61 +823,112 @@ static void ipoib_neigh_cleanup(struct neighbour *n)
> struct ipoib_neigh *neigh;
> struct ipoib_dev_priv *priv = netdev_priv(n->dev);
> unsigned long flags;
> - struct ipoib_ah *ah = NULL;
> +
> + spin_lock_irqsave(&priv->lock, flags);
>
> neigh = *to_ipoib_neigh(n);
> - if (neigh)
> - priv = netdev_priv(neigh->dev);
> - else
> + if (neigh) {
Should this be "if (!neigh)" ?
> + spin_unlock_irqrestore(&priv->lock, flags);
> return;
> + }
> + *to_ipoib_neigh(n) = NULL;
> + neigh->neighbour = NULL;
> +
--
Arthur
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-02-25 20:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 19:29 [PATCH] IB/ipoib: fix dangling pointer references to ipoib_neigh and ipoib_path Ralph Campbell
[not found] ` <1267126142.30294.25.camel-/vjeY7uYZjrPXfVEPVhPGq6RkeBMCJyt@public.gmane.org>
2010-02-25 20:03 ` Arthur Kepner [this message]
[not found] ` <20100225200357.GW29938-sJ/iWh9BUns@public.gmane.org>
2010-02-25 23:43 ` Ralph Campbell
2010-02-25 20:15 ` Roland Dreier
[not found] ` <aday6ihvzqg.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-02-26 0:41 ` Ralph Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100225200357.GW29938@sgi.com \
--to=akepner-sj/iwh9buns@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ralph.campbell-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org \
--cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox