From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arthur Kepner Subject: Re: [PATCH] IB/ipoib: fix dangling pointer references to ipoib_neigh and ipoib_path Date: Thu, 25 Feb 2010 12:03:57 -0800 Message-ID: <20100225200357.GW29938@sgi.com> References: <1267126142.30294.25.camel@chromite.mv.qlogic.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1267126142.30294.25.camel-/vjeY7uYZjrPXfVEPVhPGq6RkeBMCJyt@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ralph Campbell Cc: Roland Dreier , linux-rdma List-Id: linux-rdma@vger.kernel.org On Thu, Feb 25, 2010 at 11:29:02AM -0800, Ralph Campbell wrote: > .... I haven't looked carefully at the whole patch, but this bit looks wrong: > @@ -848,61 +823,112 @@ static void ipoib_neigh_cleanup(struct neighbour *n) > struct ipoib_neigh *neigh; > struct ipoib_dev_priv *priv = netdev_priv(n->dev); > unsigned long flags; > - struct ipoib_ah *ah = NULL; > + > + spin_lock_irqsave(&priv->lock, flags); > > neigh = *to_ipoib_neigh(n); > - if (neigh) > - priv = netdev_priv(neigh->dev); > - else > + if (neigh) { Should this be "if (!neigh)" ? > + spin_unlock_irqrestore(&priv->lock, flags); > return; > + } > + *to_ipoib_neigh(n) = NULL; > + neigh->neighbour = NULL; > + -- Arthur -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html