From: Jiri Pirko <jpirko@redhat.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
ogerlitz@voltaire.com, linux-rdma@vger.kernel.org,
monis@voltaire.com
Subject: Re: [net-next-2.6 PATCH] ipoib: remove addrlen check for mc addresses
Date: Mon, 22 Mar 2010 18:26:14 +0100 [thread overview]
Message-ID: <20100322172613.GA2884@psychotron.redhat.com> (raw)
In-Reply-To: <20100322165916.GE29129@obsidianresearch.com>
Mon, Mar 22, 2010 at 05:59:16PM CET, jgunthorpe@obsidianresearch.com wrote:
>On Mon, Mar 22, 2010 at 02:21:39PM +0100, Jiri Pirko wrote:
>> Finally this bit can be removed. Currently, after the bonding driver is
>> changed/fixed (32a806c194ea112cfab00f558482dd97bee5e44e net-next-2.6),
>> that's not possible for an addr with different length than dev->addr_len
>> to be present in list. Removing this check as in new mc_list there will be
>> no addrlen in the record.
>
>Maybe just make this check a WARN_ON?
As I said, addrlen will no longer be in record (because it would have no
meaning since length ot the addr is always dev->addr_len)
>Can userspace create a mc_list
>entry with the wrong size via netlink?
Nope - this is not possible. dev->addr_len is used.
>
>Jason
next prev parent reply other threads:[~2010-03-22 17:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 13:21 [net-next-2.6 PATCH] ipoib: remove addrlen check for mc addresses Jiri Pirko
[not found] ` <20100322132138.GC2780-YzwxZg+R7evMbnheQZGK0N5OCZ2W11yPFxja6HXR22MAvxtiuMwx3w@public.gmane.org>
2010-03-22 16:59 ` Jason Gunthorpe
2010-03-22 17:26 ` Jiri Pirko [this message]
[not found] ` <20100322172613.GA2884-YzwxZg+R7et1/kRsl7OVgNvLeJWuRmrY@public.gmane.org>
2010-03-22 17:46 ` Jason Gunthorpe
2010-03-23 1:34 ` David Miller
2010-03-23 10:30 ` Eli Cohen
[not found] ` <20100323103034.GC12224-8YAHvHwT2UEvbXDkjdHOrw/a8Rv0c6iv@public.gmane.org>
2010-03-23 10:34 ` Or Gerlitz
2010-03-23 11:34 ` Eli Cohen
2010-03-23 11:45 ` Moni Shoua
2010-03-23 11:55 ` Moni Shoua
2010-03-23 10:46 ` Moni Shoua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322172613.GA2884@psychotron.redhat.com \
--to=jpirko@redhat.com \
--cc=davem@davemloft.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-rdma@vger.kernel.org \
--cc=monis@voltaire.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@voltaire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox