public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 26/26] rdma/ucm: allow user space to specify AF_IB when joining multicast
Date: Thu, 1 Apr 2010 12:27:32 -0600	[thread overview]
Message-ID: <20100401182732.GD15629@obsidianresearch.com> (raw)
In-Reply-To: <89AF89412472472786051768B3A22420-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>

On Thu, Apr 01, 2010 at 10:46:06AM -0700, Sean Hefty wrote:
> >>  	} else if ((addr->sa_family == AF_INET6)) {
> >>  		ipv6_ib_mc_map(&sin6->sin6_addr, dev_addr->broadcast, mc_map);
> >> -		if (id_priv->id.ps == RDMA_PS_UDP)
> >> +		if (id_priv->id.ps == RDMA_PS_UDP || id_priv->id.ps ==
> RDMA_PS_IB)
> >>  			mc_map[7] = 0x01;	/* Use RDMA CM signature */
> >>  		*mgid = *(union ib_gid *) (mc_map + 4);
> >
> >What does the combination of AF_INET/INET6 and RDMA_PS_IB mean?
> 
> This indicates that the rdma_cm_id is bound to AF_IB/RDMA_PS_IB, but that the
> multicast join address was provided using AF_INET6.  The 'else' code that
> follows the above code:

Humm, interesting.. So you propose to accept addresses for families
other than the one used to create the cm_id?

Just from a simplicity of the future perspective I'd say not to bother
...

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-04-01 18:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-01 17:08 [PATCH 26/26] rdma/ucm: allow user space to specify AF_IB when joining multicast Sean Hefty
     [not found] ` <9D903E76C4EA4CF48BF2548F2BC8D2EA-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2010-04-01 17:38   ` Jason Gunthorpe
     [not found]     ` <20100401173809.GA15629-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-04-01 17:46       ` Sean Hefty
     [not found]         ` <89AF89412472472786051768B3A22420-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2010-04-01 18:27           ` Jason Gunthorpe [this message]
     [not found]             ` <20100401182732.GD15629-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-04-01 23:10               ` Sean Hefty
2010-04-07  0:49   ` [PATCH 26/26 v2] " Sean Hefty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100401182732.GD15629@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox