Re: [PATCH v3 05/10] iw_cxgb4: Add connection management functions.

Roland Dreier
2010-04-21T22:41:11Z

Thanks, all this looks pretty clean and small so I added it (as one big
patch). One tiny issue that we can fix with a follow-up patch:

> +int c4iw_ep_redirect(void *ctx, struct dst_entry *old, struct dst_entry *new,
> + struct l2t_entry *l2t)
> +{
> + struct c4iw_ep *ep = ctx;
> +
> + if (ep->dst != old)
> + return 0;
> +
> + PDBG("%s ep %p redirect to dst %p l2t %p\n", __func__, ep, new,
> + l2t);
> + dst_hold(new);
> + cxgb4_l2t_release(ep->l2t);
> + ep->l2t = l2t;
> + dst_release(old);
> + ep->dst = new;
> + return 1;
> +}

As far as I can see this function is not called or otherwise referenced
anywhere else (except for a declaration in a header). Can we drop it?
--
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to: