Re: [PATCH v3 05/10] iw_cxgb4: Add connection management functions.

Roland Dreier
2010-04-26T16:22:17Z

> > +int c4iw_ep_redirect(void *ctx, struct dst_entry *old, struct dst_entry *new,

> > As far as I can see this function is not called or otherwise referenced
> > anywhere else (except for a declaration in a header). Can we drop it?

> Yes.

OK, I rolled the following up into the big "merge iw_cxgb4" patch I have queued:

diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index e1c1ee0..b602438 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -2260,24 +2260,6 @@ int c4iw_ep_disconnect(struct c4iw_ep *ep, int abrupt, gfp_t gfp)
return ret;
}

-int c4iw_ep_redirect(void *ctx, struct dst_entry *old, struct dst_entry *new,
- struct l2t_entry *l2t)
-{
- struct c4iw_ep *ep = ctx;
-
- if (ep->dst != old)
- return 0;
-
- PDBG("%s ep %p redirect to dst %p l2t %p\n", __func__, ep, new,
- l2t);
- dst_hold(new);
- cxgb4_l2t_release(ep->l2t);
- ep->l2t = l2t;
- dst_release(old);
- ep->dst = new;
- return 1;
-}
-
/*
* All the CM events are handled on a work queue to have a safe context.
*/

--
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to: