[infiniband-diags] [2/2] check for duplicate port guids in libibnetdisc cache

[infiniband-diags] [2/2] check for duplicate port guids in libibnetdisc cache

[Al Chu]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

Hey Sasha,

This patch checks for duplicate port guids in a libibnetdisc cache when
it is loaded and report an error back to the user appropriately.

Al

-- 
Albert Chu
chu11-i2BcT+NCU+M@public.gmane.org
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory

[-- Attachment #2: 0002-check-for-duplicate-port-guids-in-libibnetdisc-cache.patch --]
[-- Type: message/rfc822, Size: 1101 bytes --]

From: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>
Subject: [PATCH] check for duplicate port guids in libibnetdisc cache
Date: Wed, 14 Apr 2010 15:25:11 -0700
Message-ID: <1271285070.17987.138.camel-X2zTWyBD0EhliZ7u+bvwcg@public.gmane.org>


Signed-off-by: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>
---
 .../libibnetdisc/src/ibnetdisc_cache.c             |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/infiniband-diags/libibnetdisc/src/ibnetdisc_cache.c b/infiniband-diags/libibnetdisc/src/ibnetdisc_cache.c
index 2ec353d..a02fcba 100644
--- a/infiniband-diags/libibnetdisc/src/ibnetdisc_cache.c
+++ b/infiniband-diags/libibnetdisc/src/ibnetdisc_cache.c
@@ -505,6 +505,11 @@ static int _fill_port(ibnd_fabric_cache_t * fabric_cache, ibnd_node_t * node,
 		return -1;
 	}
 
+	if (port_cache->port_stored_to_fabric) {
+		IBND_DEBUG("Cache invalid: duplicate port discovered\n");
+		return -1;
+	}
+
 	node->ports[port_cache->port->portnum] = port_cache->port;
 	port_cache->port_stored_to_fabric++;
 
-- 
1.5.4.5

Re: [infiniband-diags] [2/2] check for duplicate port guids in libibnetdisc cache

[Sasha Khapyorsky]

On 15:48 Wed 14 Apr     , Al Chu wrote:
> Hey Sasha,
> 
> This patch checks for duplicate port guids in a libibnetdisc cache when
> it is loaded and report an error back to the user appropriately.
> 
> Al
> 
> -- 
> Albert Chu
> chu11-i2BcT+NCU+M@public.gmane.org
> Computer Scientist
> High Performance Systems Division
> Lawrence Livermore National Laboratory

> Date: Wed, 14 Apr 2010 15:25:11 -0700
> From: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>
> Subject: [PATCH] check for duplicate port guids in libibnetdisc cache
> Message-Id: <1271285070.17987.138.camel-X2zTWyBD0EhliZ7u+bvwcg@public.gmane.org>
> Mime-Version: 1.0
> Content-Transfer-Encoding: 7bit
> 
> 
> Signed-off-by: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>

Applied. Thanks.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html