From: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Eli Dorfman <elid-smomgflXvOZWk0Htik3J/w@public.gmane.org>,
Alex Netes <alexne-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH] opensm/osm_lid_mgr: use 'first_time_master_sweep' flag
Date: Sat, 22 May 2010 16:09:41 +0300 [thread overview]
Message-ID: <20100522130941.GP28549@me> (raw)
In-Reply-To: <20100426104838.GS23994@me>
On 13:48 Mon 26 Apr , Sasha Khapyorsky wrote:
>
> Use 'first_time_master_sweep' as initial sweep indication instead of
> 'coming_out_of_standby'. The last flag will be set only when OpenSM
> previously was in standby state, this doesn't cover some other cases
> such as temporary SM port disconnection.
>
> Signed-off-by: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
> ---
> opensm/opensm/osm_lid_mgr.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/opensm/opensm/osm_lid_mgr.c b/opensm/opensm/osm_lid_mgr.c
> index 0fd3b20..84f3508 100644
> --- a/opensm/opensm/osm_lid_mgr.c
> +++ b/opensm/opensm/osm_lid_mgr.c
> @@ -304,7 +304,7 @@ static int lid_mgr_init_sweep(IN osm_lid_mgr_t * p_mgr)
> info we might have.
> Do this only if the honor_guid2lid_file option is FALSE. If not, then
> need to honor this file. */
> - if (p_mgr->p_subn->coming_out_of_standby == TRUE) {
> + if (p_mgr->p_subn->first_time_master_sweep == TRUE) {
Actually this changes the current behavior. Flag 'coming_out_of_standby'
is not set on first initial sweep and 'first_time_master_sweep' is. So
I'm reverting this patch yet up to more cleanup will be performed.
Sasha
> osm_db_clear(p_mgr->p_g2l);
> if (p_mgr->p_subn->opt.honor_guid2lid_file == FALSE) {
> OSM_LOG(p_mgr->p_log, OSM_LOG_DEBUG,
> --
> 1.7.0.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-05-22 13:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 10:48 [PATCH] opensm/osm_lid_mgr: use 'first_time_master_sweep' flag Sasha Khapyorsky
2010-04-26 12:16 ` [PATCH] opensm/osm_lid_mgr: fix couple of duplicate LIDs bugs Sasha Khapyorsky
2010-04-26 13:02 ` [PATCH v2] " Sasha Khapyorsky
2010-05-22 13:09 ` Sasha Khapyorsky [this message]
2010-05-22 13:16 ` [PATCH] opensm/osm_lid_mgr: revert 'coming_out_of_standby' replacement patch Sasha Khapyorsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100522130941.GP28549@me \
--to=sashak-smomgflxvozwk0htik3j/w@public.gmane.org \
--cc=alexne-smomgflXvOZWk0Htik3J/w@public.gmane.org \
--cc=elid-smomgflXvOZWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox