public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: "Smith, Stan" <stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "ofw-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org"
	<ofw-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] use macro for tmp file path
Date: Tue, 25 May 2010 14:02:06 +0300	[thread overview]
Message-ID: <20100525110206.GO28549@me> (raw)
In-Reply-To: <3F6F638B8D880340AB536D29CD4C1E192562EBBB00-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>

On 09:51 Fri 21 May     , Smith, Stan wrote:
> 
> Use defined macro for tmp file path
> 
> signed-off-by: stan smith <stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 

The patch is whitespece-mangled.

> diff --git a/opensm/opensm/st.c b/opensm/opensm/st.c
> index ea76038..2d39117 100644
> --- a/opensm/opensm/st.c
> +++ b/opensm/opensm/st.c
> @@ -174,7 +174,7 @@ static int init_st = 0;
> 
>  static void stat_col()
>  {
> -       FILE *f = fopen("/var/log/osm_st_col", "w");
> +       FILE *f = fopen( OSM_DEFAULT_TMP_DIR "osm_st_col", "w");

I think it was discussed somehow in the past.

Shouldn't this be:

	OSM_DEFAULT_TMP_DIR "/osm_st_col"

, so that trailing '/' will not be mandatory in directory define?

Sasha

>         fprintf(f, "collision: %d\n", collision);
>         fclose(f);
>  }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-05-25 11:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-21 16:51 [PATCH] use macro for tmp file path Smith, Stan
     [not found] ` <3F6F638B8D880340AB536D29CD4C1E192562EBBB00-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-05-25 11:02   ` Sasha Khapyorsky [this message]
2010-05-25 15:25     ` Smith, Stan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100525110206.GO28549@me \
    --to=sashak-smomgflxvozwk0htik3j/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ofw-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org \
    --cc=stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox