[PATCH] use macro for tmp file path

[PATCH] use macro for tmp file path

[Smith, Stan]

Use defined macro for tmp file path

signed-off-by: stan smith <stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

diff --git a/opensm/opensm/st.c b/opensm/opensm/st.c
index ea76038..2d39117 100644
--- a/opensm/opensm/st.c
+++ b/opensm/opensm/st.c
@@ -174,7 +174,7 @@ static int init_st = 0;

 static void stat_col()
 {
-       FILE *f = fopen("/var/log/osm_st_col", "w");
+       FILE *f = fopen( OSM_DEFAULT_TMP_DIR "osm_st_col", "w");
        fprintf(f, "collision: %d\n", collision);
        fclose(f);
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] use macro for tmp file path

[Sasha Khapyorsky]

On 09:51 Fri 21 May     , Smith, Stan wrote:
> 
> Use defined macro for tmp file path
> 
> signed-off-by: stan smith <stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 

The patch is whitespece-mangled.

> diff --git a/opensm/opensm/st.c b/opensm/opensm/st.c
> index ea76038..2d39117 100644
> --- a/opensm/opensm/st.c
> +++ b/opensm/opensm/st.c
> @@ -174,7 +174,7 @@ static int init_st = 0;
> 
>  static void stat_col()
>  {
> -       FILE *f = fopen("/var/log/osm_st_col", "w");
> +       FILE *f = fopen( OSM_DEFAULT_TMP_DIR "osm_st_col", "w");

I think it was discussed somehow in the past.

Shouldn't this be:

	OSM_DEFAULT_TMP_DIR "/osm_st_col"

, so that trailing '/' will not be mandatory in directory define?

Sasha

>         fprintf(f, "collision: %d\n", collision);
>         fclose(f);
>  }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] use macro for tmp file path

[Smith, Stan]

Sasha Khapyorsky wrote:
> On 09:51 Fri 21 May     , Smith, Stan wrote:
>>
>> Use defined macro for tmp file path
>>
>> signed-off-by: stan smith <stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>>
>
> The patch is whitespece-mangled.
>
>> diff --git a/opensm/opensm/st.c b/opensm/opensm/st.c
>> index ea76038..2d39117 100644
>> --- a/opensm/opensm/st.c
>> +++ b/opensm/opensm/st.c
>> @@ -174,7 +174,7 @@ static int init_st = 0;
>>
>>  static void stat_col()
>>  {
>> -       FILE *f = fopen("/var/log/osm_st_col", "w");
>> +       FILE *f = fopen( OSM_DEFAULT_TMP_DIR "osm_st_col", "w");
>
> I think it was discussed somehow in the past.
>
> Shouldn't this be:
>
>       OSM_DEFAULT_TMP_DIR "/osm_st_col"
>
> , so that trailing '/' will not be mandatory in directory define?

Currently OSM_DEFAULT_TMP_DIR is defined with a trailing directory delimiter.
Having the delimiter in the OSM_DEFAULT_TMP_DIR makes it easier to be consistent with \ or /.
Will resend this patch as I think I've figured out the mangled email story.

>
> Sasha
>
>>         fprintf(f, "collision: %d\n", collision);
>>         fclose(f);
>>  }
>> --
>> To unsubscribe from this list: send the line "unsubscribe
>> linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html