From: Eli Cohen <eli@dev.mellanox.co.il>
To: David Miller <davem@davemloft.net>
Cc: eli@mellanox.co.il, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, rdreier@cisco.com,
yevgenyp@mellanox.co.il
Subject: Re: [PATCH] net/core: Save the port number a netdevice uses
Date: Wed, 26 May 2010 12:08:52 +0300 [thread overview]
Message-ID: <20100526090850.GB28748@mtldesk030.lab.mtl.com> (raw)
In-Reply-To: <20100526.015526.102555441.davem@davemloft.net>
On Wed, May 26, 2010 at 01:55:26AM -0700, David Miller wrote:
> From: Eli Cohen <eli@dev.mellanox.co.il>
> Date: Wed, 26 May 2010 11:45:23 +0300
>
>
> What's wrong with using the existing dev_id sysfs file name and saying
> that it means the port number of the card?
>
> Nobody, and I really mean nobody, uses this thing any more.
>
> It used to be a way for devices like the qeth driver to get it's
> IPV6 EUI48 value set properly for local IPV6 addresses assigned
> to the device, but that got fixed in a different way.
>
> So we can use this value however we wish now, and it defaults to zero
> for every single device now, and is propagated across VLAN devices,
> which is perfect.
OK. So if I understand you correctly, you think that I should not
bother to set a default value of 1. Each driver that cares about the
value of this field, will set it however they want.
next prev parent reply other threads:[~2010-05-26 9:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 8:17 [PATCH] net/core: Save the port number a netdevice uses Eli Cohen
2010-05-26 8:39 ` David Miller
[not found] ` <20100526.013926.28807066.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-05-26 8:45 ` Eli Cohen
[not found] ` <20100526084523.GA28748-8YAHvHwT2UEvbXDkjdHOrw/a8Rv0c6iv@public.gmane.org>
2010-05-26 8:55 ` David Miller
2010-05-26 9:08 ` Eli Cohen [this message]
[not found] ` <20100526090850.GB28748-8YAHvHwT2UEvbXDkjdHOrw/a8Rv0c6iv@public.gmane.org>
2010-05-26 9:16 ` David Miller
[not found] ` <20100526.021635.179940939.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-05-26 9:19 ` Eli Cohen
2010-06-02 16:42 ` Ben Hutchings
[not found] ` <1275496949.2115.18.camel-xQnnTUlwzDrdvaEqJLTMTA9jg9n5Vt1AMm0uRHvK7Nw@public.gmane.org>
2010-06-02 17:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526090850.GB28748@mtldesk030.lab.mtl.com \
--to=eli@dev.mellanox.co.il \
--cc=davem@davemloft.net \
--cc=eli@mellanox.co.il \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox