* [patch 1/2] infiniband/cxgb4: remove unneeded assignment
@ 2010-05-31 14:00 Dan Carpenter
2010-06-02 21:56 ` Roland Dreier
2010-07-19 20:09 ` Roland Dreier
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-05-31 14:00 UTC (permalink / raw)
To: Steve Wise
Cc: Roland Dreier, Sean Hefty, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
We don't need to assign rpl here, we do that later on.
Signed-off-by: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 30ce0a8..60b5beb 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -2242,7 +2242,7 @@ static void process_work(struct work_struct *work)
{
struct sk_buff *skb = NULL;
struct c4iw_dev *dev;
- struct cpl_act_establish *rpl = cplhdr(skb);
+ struct cpl_act_establish *rpl;
unsigned int opcode;
int ret;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch 1/2] infiniband/cxgb4: remove unneeded assignment
2010-05-31 14:00 [patch 1/2] infiniband/cxgb4: remove unneeded assignment Dan Carpenter
@ 2010-06-02 21:56 ` Roland Dreier
[not found] ` <adaiq61qesj.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-07-19 20:09 ` Roland Dreier
1 sibling, 1 reply; 4+ messages in thread
From: Roland Dreier @ 2010-06-02 21:56 UTC (permalink / raw)
To: Dan Carpenter
Cc: Steve Wise, Roland Dreier, Sean Hefty, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
Looks fine to me... in fact I don't see how this could have avoided a
NULL deref here unless the compiler is already optimizing out this
assignment, since two lines above is
struct sk_buff *skb = NULL;
before we do
- struct cpl_act_establish *rpl = cplhdr(skb);
Steve?
--
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 1/2] infiniband/cxgb4: remove unneeded assignment
[not found] ` <adaiq61qesj.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
@ 2010-06-03 2:42 ` Steve Wise
0 siblings, 0 replies; 4+ messages in thread
From: Steve Wise @ 2010-06-03 2:42 UTC (permalink / raw)
To: Roland Dreier
Cc: Dan Carpenter, Steve Wise, Roland Dreier, Sean Hefty,
Hal Rosenstock, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
Roland Dreier wrote:
> Looks fine to me... in fact I don't see how this could have avoided a
> NULL deref here unless the compiler is already optimizing out this
> assignment, since two lines above is
>
> struct sk_buff *skb = NULL;
>
> before we do
>
> - struct cpl_act_establish *rpl = cplhdr(skb);
>
> Steve?
>
Looks ok.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 1/2] infiniband/cxgb4: remove unneeded assignment
2010-05-31 14:00 [patch 1/2] infiniband/cxgb4: remove unneeded assignment Dan Carpenter
2010-06-02 21:56 ` Roland Dreier
@ 2010-07-19 20:09 ` Roland Dreier
1 sibling, 0 replies; 4+ messages in thread
From: Roland Dreier @ 2010-07-19 20:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: Steve Wise, Roland Dreier, Sean Hefty, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
thanks, applied.
--
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-19 20:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-31 14:00 [patch 1/2] infiniband/cxgb4: remove unneeded assignment Dan Carpenter
2010-06-02 21:56 ` Roland Dreier
[not found] ` <adaiq61qesj.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-06-03 2:42 ` Steve Wise
2010-07-19 20:09 ` Roland Dreier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox