public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Stan Smith <stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] opensm/osm_sa.c: In osm_sa_respond, only fill in attr offset if RMPP method
Date: Wed, 9 Jun 2010 15:48:48 +0300	[thread overview]
Message-ID: <20100609124848.GE20172@me> (raw)
In-Reply-To: <AANLkTikTxpvb-Nw2V1PrBcX4rZ1GwElXV22CBtBZx1iK-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 08:40 Wed 09 Jun     , Hal Rosenstock wrote:
> 
> I think the use of ib_get_attr_offset is being "overused". I'd rather
> see this patch used as it is the simplest way to address that rather
> than conditionalize ib_get_attr_offset on the SA attribute or would
> you rather see a patch along those lines ?

I just think that if the assertion is incorrect (and ib_get_attr_offset()
is generic function) we need to remove this. That is simplest.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-06-09 12:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-03 13:42 [PATCH] opensm/osm_sa.c: In osm_sa_respond, only fill in attr offset if RMPP method Hal Rosenstock
     [not found] ` <20100603134209.GA12225-Wuw85uim5zDR7s880joybQ@public.gmane.org>
2010-06-09  5:43   ` Sasha Khapyorsky
2010-06-09 10:23     ` Hal Rosenstock
     [not found]       ` <AANLkTilkr6KYG_TVJYwvNl7sZ8XBKmFljktxg8qCA9t9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-09 12:10         ` Sasha Khapyorsky
2010-06-09 12:40           ` Hal Rosenstock
     [not found]             ` <AANLkTikTxpvb-Nw2V1PrBcX4rZ1GwElXV22CBtBZx1iK-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-09 12:48               ` Sasha Khapyorsky [this message]
2010-06-09 15:27                 ` Hal Rosenstock
     [not found]                   ` <AANLkTinxeLPtxYPvPBZfWq96BZjxDqcAlCzP2v_1VJnv-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-09 17:15                     ` Sasha Khapyorsky
2010-06-09 18:51                       ` Hal Rosenstock
2010-06-10 15:18                       ` Smith, Stan
2010-06-11 16:02                       ` Smith, Stan
     [not found]                         ` <3F6F638B8D880340AB536D29CD4C1E1925634C8F42-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-06-11 19:04                           ` Hal Rosenstock
2010-06-11 16:44                       ` Smith, Stan
     [not found]                         ` <3F6F638B8D880340AB536D29CD4C1E1925634C8FE9-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-06-14 13:04                           ` [PATCH] iba/ib_types.h: remove assertion in ib_get_attr_offset() Sasha Khapyorsky
2010-06-14 16:16                             ` Hefty, Sean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100609124848.GE20172@me \
    --to=sashak-smomgflxvozwk0htik3j/w@public.gmane.org \
    --cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox