From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Khapyorsky Subject: Re: [PATCH] opensm/osm_sa.c: In osm_sa_respond, only fill in attr offset if RMPP method Date: Wed, 9 Jun 2010 20:15:16 +0300 Message-ID: <20100609171516.GI20172@me> References: <20100603134209.GA12225@comcast.net> <20100609054341.GK28549@me> <20100609121036.GC20172@me> <20100609124848.GE20172@me> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hal Rosenstock Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stan Smith List-Id: linux-rdma@vger.kernel.org On 11:27 Wed 09 Jun , Hal Rosenstock wrote: > On Wed, Jun 9, 2010 at 8:48 AM, Sasha Khapyorsky wrote: > > On 08:40 Wed 09 Jun =A0 =A0 , Hal Rosenstock wrote: > >> > >> I think the use of ib_get_attr_offset is being "overused". I'd rat= her > >> see this patch used as it is the simplest way to address that rath= er > >> than conditionalize ib_get_attr_offset on the SA attribute or woul= d > >> you rather see a patch along those lines ? > > > > I just think that if the assertion is incorrect (and ib_get_attr_of= fset() > > is generic function) we need to remove this. That is simplest. >=20 > The downside is that it loses the ability to catch SA records which > were not properly padded out. It is not run-time error, so I don't think that such sort of debugging is a main function of OpenSM. > It seems like a reasonable tradeoff to > me to not set this field on the transmit side when it's going to be > ignored on receive (treat it like a reserved field for this case) and > keep the ability to catch the SA record issue which has bit the > community a number of times. This will cost in extra code. > The only other approach I see to maintain this is to add an additiona= l > calling parameter (allribute ID) to get_attr_offset and then inside > check the attribute ID and return 0 for those SA attributes. Which SA attributes? Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html