From: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: "Smith,
Stan" <stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH] iba/ib_types.h: remove assertion in ib_get_attr_offset()
Date: Mon, 14 Jun 2010 16:04:04 +0300 [thread overview]
Message-ID: <20100614130404.GZ20172@me> (raw)
In-Reply-To: <3F6F638B8D880340AB536D29CD4C1E1925634C8FE9-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
This reverts the commit:
commit 7fc6cd3037f07190e483a047f17d37b6bebbb2b3
Author: Smith, Stan <stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Date: Fri May 21 10:49:27 2010 -0700
ib_types.h add debug assert
Add a debug assert to catch incorrect MAD attr offset size.
This proved to be useful in catching incorrect struct sizes as MAD attrs need to be a multiple of 8 bytes.
Since not all SA attributes should be multiple of 8 bytes (specifically
InformInfo).
The issue was discovered by Hal Rosenstock.
Signed-off-by: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
---
opensm/include/iba/ib_types.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/opensm/include/iba/ib_types.h b/opensm/include/iba/ib_types.h
index 203c319..e1bc102 100644
--- a/opensm/include/iba/ib_types.h
+++ b/opensm/include/iba/ib_types.h
@@ -4395,7 +4395,6 @@ static inline uint32_t OSM_API ib_get_attr_size(IN const ib_net16_t attr_offset)
static inline ib_net16_t OSM_API ib_get_attr_offset(IN const uint32_t attr_size)
{
- CL_ASSERT((attr_size & 0x07) == 0);
return (cl_hton16((uint16_t) (attr_size >> 3)));
}
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-06-14 13:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 13:42 [PATCH] opensm/osm_sa.c: In osm_sa_respond, only fill in attr offset if RMPP method Hal Rosenstock
[not found] ` <20100603134209.GA12225-Wuw85uim5zDR7s880joybQ@public.gmane.org>
2010-06-09 5:43 ` Sasha Khapyorsky
2010-06-09 10:23 ` Hal Rosenstock
[not found] ` <AANLkTilkr6KYG_TVJYwvNl7sZ8XBKmFljktxg8qCA9t9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-09 12:10 ` Sasha Khapyorsky
2010-06-09 12:40 ` Hal Rosenstock
[not found] ` <AANLkTikTxpvb-Nw2V1PrBcX4rZ1GwElXV22CBtBZx1iK-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-09 12:48 ` Sasha Khapyorsky
2010-06-09 15:27 ` Hal Rosenstock
[not found] ` <AANLkTinxeLPtxYPvPBZfWq96BZjxDqcAlCzP2v_1VJnv-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-09 17:15 ` Sasha Khapyorsky
2010-06-09 18:51 ` Hal Rosenstock
2010-06-10 15:18 ` Smith, Stan
2010-06-11 16:02 ` Smith, Stan
[not found] ` <3F6F638B8D880340AB536D29CD4C1E1925634C8F42-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-06-11 19:04 ` Hal Rosenstock
2010-06-11 16:44 ` Smith, Stan
[not found] ` <3F6F638B8D880340AB536D29CD4C1E1925634C8FE9-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-06-14 13:04 ` Sasha Khapyorsky [this message]
2010-06-14 16:16 ` [PATCH] iba/ib_types.h: remove assertion in ib_get_attr_offset() Hefty, Sean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614130404.GZ20172@me \
--to=sashak-smomgflxvozwk0htik3j/w@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox