Re: [ewg] [PATCH v4] IB Core: RAW ETH support

Roland Dreier
2010-06-23T17:31:52Z

> There is no qp type IBV_QPT_RAW_ETY in user space (at least not in the definitions
> coming with libibverbs). In fact, libibverbs that comes with OFED defines (in verbs.h)
> a qp type called IBV_QPT_RAW_ETT which equals to 7.
> The patch that is under discussion here adds a new qp type IB_QPT_RAW_ETH and equals it to 7
> to match the definition in user space. This indeed changes the value of IB_QPT_RAW_ETY to 8
> but I don't see who can be affected since
> 1. No user space program that uses IB_QPT_RAW_ETY exists
> 2. kernel is compiled as one piece of code.

Why renumber the _ETY enum? Maybe it doesn't break anything serious but
why risk it?
--
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to: