Re: mlx4 pci device table

Jason Gunthorpe
2010-06-28T20:26:33Z

On Mon, Jun 28, 2010 at 10:55:50PM +0300, Tziporet Koren wrote:
> On 6/28/2010 4:11 PM, Or Gerlitz wrote:
>
> > Roland Dreier wrote:
> >> I think the current upstream location is correct. This matches the practice of eg iw_cxgb3 as well as cxgb3i, bnx2i >> etc. This does have the disadvantage that mlx4_en and mlx4_ib are not auto-loaded by PCI hotplug, but so it goes.
>
> > okay. Still, its too bad that ofed ships patches that do things the
> > other way around vs upstream. Yevgeny, if you have reasoning in place to
> > do things the other way, why not submit upstream?

> This patch was submitted to upstream but was not accepted. however
> without it PXE boot cannot work since only mlx4_core is loaded and
> not the Eth driver

Sigh.. Please realize that creating something which is an aggregation
of stuff that upstream has refused is an extremely bad idea?

> Any other suggestion how to solve it will be accepted.

Yes, you build the initrd properly! All distro initrd scripts have an
option to include named modules, specifically for cases like this. If
you are PXE booting over IB then you need to use those options to
include the mlx driver, ipoib driver, etc, etc.

Jason