public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Cc: Or Gerlitz <ogerlitz-hKgKHo2Ms0FWk0Htik3J/w@public.gmane.org>,
	Sean Hefty <mshefty-+/W+9+QloQG75v1z/vFq2g@public.gmane.org>,
	linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: sense remote hardware address change by rdma-cm applications
Date: Tue, 20 Jul 2010 12:46:20 -0600	[thread overview]
Message-ID: <20100720184620.GJ7920@obsidianresearch.com> (raw)
In-Reply-To: <4C45E701.7030501-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>

On Tue, Jul 20, 2010 at 01:12:17PM -0500, Steve Wise wrote:

> The cxgb* drivers actually reference the neigh and dst structs until the  
> offload connection is gone.  Also if the the offloaded connection has  
> problems transmitting (due to a L2 address change, for example), then  
> the driver will initiate ND again by calling neigh_event_send().  See  
> t4_l2t_send_event() in l2t.c which is called by the iwarp driver in  
> peer_abort() from iwch_cm.c when the HW tells us its retransmitting too  
> much.

That strikes me as mildly scary.. The cxgb can't possibly get the
right dst (ie, the same dst that the RDMA CM got) in all the corner
cases? Ie how can setting oif to 0 in iwch_cm.c:find_route be right??

So, looks like there is a larger cleanup here, if the RDMACM holds the
dst and has functions to freshen it/track it then the iwarp driver
should rely on the RDMACM to manage the dst..

In other words, moving the dst handling from iwch_cm into RDMACM would
also mostly satisfy why Or is trying to do.

Does that make sense to you Steve?

How does the cxgb3 driver know when to update the HW if the dst/nd
entries change?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-07-20 18:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-19 21:42 sense remote hardware address change by rdma-cm applications Or Gerlitz
     [not found] ` <AANLkTimmWiNqHJIqSEKbY-X6mSx6zA19p__JDYPEmp8b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-20  0:14   ` Jason Gunthorpe
     [not found]     ` <20100720001436.GH7920-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-07-20  7:25       ` Or Gerlitz
     [not found]         ` <4C454F80.1060808-hKgKHo2Ms0FWk0Htik3J/w@public.gmane.org>
2010-07-20 17:22           ` Jason Gunthorpe
2010-07-20 18:12           ` Steve Wise
     [not found]             ` <4C45E701.7030501-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-07-20 18:46               ` Jason Gunthorpe [this message]
     [not found]                 ` <20100720184620.GJ7920-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-07-20 19:20                   ` Steve Wise
     [not found]                     ` <4C45F6F5.6050008-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-07-20 20:30                       ` Jason Gunthorpe
     [not found]                         ` <20100720203044.GK7920-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-07-20 20:50                           ` Steve Wise
     [not found]                             ` <4C460BFD.5010707-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-07-20 20:57                               ` Jason Gunthorpe
     [not found]                                 ` <20100720205746.GL7920-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-07-20 21:03                                   ` Steve Wise
     [not found]                                     ` <4C460F08.7030304-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-07-20 21:15                                       ` Steve Wise
2010-07-21 14:40                                   ` Or Gerlitz
2010-07-21 14:33               ` Or Gerlitz
     [not found]                 ` <4C47053B.3000802-hKgKHo2Ms0FWk0Htik3J/w@public.gmane.org>
2010-07-21 15:48                   ` Steve Wise
     [not found]                     ` <4C4716D8.2040902-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-07-22  8:18                       ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100720184620.GJ7920@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mshefty-+/W+9+QloQG75v1z/vFq2g@public.gmane.org \
    --cc=ogerlitz-hKgKHo2Ms0FWk0Htik3J/w@public.gmane.org \
    --cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox