From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eli Cohen Subject: Re: [PATCHv9 09/12] ib_core: Add VLAN support to IBoE Date: Tue, 17 Aug 2010 17:36:23 +0300 Message-ID: <20100817143623.GA626@mtldesk30> References: <20100806144153.GJ20588@mtldesk30> <20100806164915.GL11306@obsidianresearch.com> <20100816125128.GB22111@mtldesk30> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roland Dreier Cc: Jason Gunthorpe , RDMA list List-Id: linux-rdma@vger.kernel.org On Mon, Aug 16, 2010 at 03:17:42PM -0700, Roland Dreier wrote: > > I'm having a hard time figuring out what this sentence has to do with > this patch. I don't see anywhere in the patch where the sl field is > used except for copying the TOS into it, and I don't see what "user > priority field" might be referring to. (per the RoCE spec) the 3 LSbs of the SL in the address vector carry the value that is meant to be used in the 802.1Q priority field (user_priority). > > Also, how do VLANs work with multicast? As far as I can tell, there are > no spare bits in an IB MGID or IPv6 multicast address that can be stolen > to use for a VLAN ID. For example, how would I create an AH to use to > send to MGID ff02::1 on VLAN 25? > We take the VLAN from the SGID. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html