Re: [PATCHv9 09/12] ib_core: Add VLAN support to IBoE

Eli Cohen
2010-08-17T14:36:23Z

On Mon, Aug 16, 2010 at 03:17:42PM -0700, Roland Dreier wrote:
>
> I'm having a hard time figuring out what this sentence has to do with
> this patch. I don't see anywhere in the patch where the sl field is
> used except for copying the TOS into it, and I don't see what "user
> priority field" might be referring to.
(per the RoCE spec) the 3 LSbs of the SL in the address vector carry
the value that is meant to be used in the 802.1Q priority field
(user_priority).

>
> Also, how do VLANs work with multicast? As far as I can tell, there are
> no spare bits in an IB MGID or IPv6 multicast address that can be stolen
> to use for a VLAN ID. For example, how would I create an AH to use to
> send to MGID ff02::1 on VLAN 25?
>
We take the VLAN from the SGID.