[PATCH] IB/ipoib: Initialize ipoib_neigh list properly

[PATCH] IB/ipoib: Initialize ipoib_neigh list properly

[Ira Weiny]

I applied Ralph's "fix dangling pointer references to ipoib_neigh and
ipoib_path" patch to our local RHEL based kernel and experienced crashes in
ipoib_neigh_cleanup.  It turns out ipoib_neigh->list was not initialized
properly.  So the following code from Ralph's patch caused issues.

	if (ipoib_cm_get(neigh))
		ipoib_cm_destroy_tx(ipoib_cm_get(neigh));

Looking at Rolands upstream kernel it appears the same is true upstream.

The patch below initializes ipoib_neigh->list correctly.


Signed-off-by: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
---
 drivers/infiniband/ulp/ipoib/ipoib_main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
index b4b2257..fa38ede 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -882,6 +882,7 @@ struct ipoib_neigh *ipoib_neigh_alloc(struct neighbour *neighbour,
 	if (!neigh)
 		return NULL;
 
+	INIT_LIST_HEAD(&neigh->list);
 	neigh->neighbour = neighbour;
 	neigh->dev = dev;
 	memset(&neigh->dgid.raw, 0, sizeof (union ib_gid));
-- 
1.5.4.5

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/ipoib: Initialize ipoib_neigh list properly

[Ralph Campbell]

You are correct that it needs to be initialized but I
think you must have made an error in applying the patch.

If you look again at the latest version of the patch
this line is present.
https://patchwork.kernel.org/patch/120013/

On Tue, 2010-08-24 at 20:51 -0700, Ira Weiny wrote:
> I applied Ralph's "fix dangling pointer references to ipoib_neigh and
> ipoib_path" patch to our local RHEL based kernel and experienced crashes in
> ipoib_neigh_cleanup.  It turns out ipoib_neigh->list was not initialized
> properly.  So the following code from Ralph's patch caused issues.
> 
> 	if (ipoib_cm_get(neigh))
> 		ipoib_cm_destroy_tx(ipoib_cm_get(neigh));
> 
> Looking at Rolands upstream kernel it appears the same is true upstream.
> 
> The patch below initializes ipoib_neigh->list correctly.
> 
> 
> Signed-off-by: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
> ---
>  drivers/infiniband/ulp/ipoib/ipoib_main.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> index b4b2257..fa38ede 100644
> --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> @@ -882,6 +882,7 @@ struct ipoib_neigh *ipoib_neigh_alloc(struct neighbour *neighbour,
>  	if (!neigh)
>  		return NULL;
>  
> +	INIT_LIST_HEAD(&neigh->list);
>  	neigh->neighbour = neighbour;
>  	neigh->dev = dev;
>  	memset(&neigh->dgid.raw, 0, sizeof (union ib_gid));


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/ipoib: Initialize ipoib_neigh list properly

[Ira Weiny]

On Mon, 30 Aug 2010 14:56:43 -0700
Ralph Campbell <ralph.campbell-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org> wrote:

> You are correct that it needs to be initialized but I
> think you must have made an error in applying the patch.
> 
> If you look again at the latest version of the patch
> this line is present.
> https://*patchwork.kernel.org/patch/120013/

Yep,  :-(  I must have made a mistake in applying the patch.  It did not apply
to our old kernel so I had to do some stuff by hand...  :-(

Sorry for the noise,
Ira

> 
> On Tue, 2010-08-24 at 20:51 -0700, Ira Weiny wrote:
> > I applied Ralph's "fix dangling pointer references to ipoib_neigh and
> > ipoib_path" patch to our local RHEL based kernel and experienced crashes in
> > ipoib_neigh_cleanup.  It turns out ipoib_neigh->list was not initialized
> > properly.  So the following code from Ralph's patch caused issues.
> > 
> > 	if (ipoib_cm_get(neigh))
> > 		ipoib_cm_destroy_tx(ipoib_cm_get(neigh));
> > 
> > Looking at Rolands upstream kernel it appears the same is true upstream.
> > 
> > The patch below initializes ipoib_neigh->list correctly.
> > 
> > 
> > Signed-off-by: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
> > ---
> >  drivers/infiniband/ulp/ipoib/ipoib_main.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> > index b4b2257..fa38ede 100644
> > --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> > +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> > @@ -882,6 +882,7 @@ struct ipoib_neigh *ipoib_neigh_alloc(struct neighbour *neighbour,
> >  	if (!neigh)
> >  		return NULL;
> >  
> > +	INIT_LIST_HEAD(&neigh->list);
> >  	neigh->neighbour = neighbour;
> >  	neigh->dev = dev;
> >  	memset(&neigh->dgid.raw, 0, sizeof (union ib_gid));
> 
> 
> 


-- 
Ira Weiny
Math Programmer/Computer Scientist
Lawrence Livermore National Lab
925-423-8008
weiny2-i2BcT+NCU+M@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html